Skip Menu |

This queue is for tickets about the Quota CPAN distribution.

Report information
The Basics
Id: 64509
Status: rejected
Priority: 0/
Queue: Quota

People
Owner: Nobody in particular
Requestors: SILASMONK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Please review long standing Debian patch
This perl module has had its Makefile patched on Debian since 2004. I am not entirely clear that this is a Debian specific problem and I am forwarding it upstream for review. The report is http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=229396. The patch is attached.
Subject: 01_Makefile.PL-remove-unneeded-objects.patch
Author: Elie Rosenblum <fnord@debian.org> Description: Remove Makefile.PL code to compile some stuff without -fPIC Bug: #229396 --- a/Makefile.PL +++ b/Makefile.PL @@ -102,14 +102,6 @@ " } - # objects that must not be compiled with the CCCDL arguments - - if (defined $extraobj) { - ($extrac = $extraobj) =~ s/\.o(\s+|$)/.c/g; - $ret .= "\n$extraobj :\n\t". - '$(CC) -c $(INC) $(CCFLAGS) $(OPTIMIZE) '."$extrac\n\n"; - } - # extract objects from a library to link them in statically # for lame OSes that have problems with LD_PATH recording in DLOs
This issue should already be fixed since release 1.5.1 (July 2005) according to the change log: "Makefile fix for Linux: compile linuxapi.c with default CFLAGS because 64-bit systems require -fPIC". Since this change linuxapi.o is handled by a separate list and no longer part of $extraobj. As far as I remember the file vxquotactl.c which is handled by $extraobj isn't even included in the Debian version. So I'd suggest to simply remove this patch and then check if the package still compiles on all architectures. -tom