Skip Menu |

This queue is for tickets about the Net-Appliance-Session CPAN distribution.

Report information
The Basics
Id: 64450
Status: resolved
Priority: 0/
Queue: Net-Appliance-Session

People
Owner: Nobody in particular
Requestors: steve [...] computurn.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.103641
Fixed in: (no value)



Subject: close() not working due to deep recursion fix
The fix to prevent deep recursion in close() prevents it being called properly at all due to close() being called by Net::Telnet open() and fhopen(). The fix is to set close_called to 0 after calling open() and fhopen().
Subject: Session.pm

Message body is not shown because it is too large.

Subject: Session.pm.diff
197,199d196 < ## Reset close_called < $self->close_called(0); < 203,215d199 < < ## Override Net::Telnet::open to reset close_called. < sub open { < my ($self, @args) = @_; < my $ok = $self->SUPER::open(@args); < < ## Reset close_called < $self->close_called(0); < < return $ok; < } < <
On Tue Jan 04 06:02:05 2011, STEVEC wrote: Show quoted text
> The fix to prevent deep recursion in close() prevents it being called > properly at all due to close() being called by Net::Telnet open() and > fhopen(). > > The fix is to set close_called to 0 after calling open() and fhopen().
Thanks for the patch, very much appreciated. I've applied it and pushed a new release to CPAN. Please let me know how you get on. regards, oliver.