Subject: | vendor field needs entity encoding |
Date: | Thu, 30 Dec 2010 14:24:54 -0800 (PST) |
To: | bug-Nmap-Scanner [...] rt.cpan.org |
From: | eponymous alias <eponymousalias [...] yahoo.com> |
The Nmap/Scanner/Address.pm and Nmap/Scanner/OS/Class.pm files
in the 1.0 release need to have HTML::Entities::encode_entities()
applied to the "vendor" field when XML is being generated. We have
seen the following output from nmap:
<osclass type="media device" vendor="AT&T" osfamily="Windows"
osgen="PocketPC/CE" accuracy="100" />
which is properly parsed by Nmap::Scanner, with the vendor field
value ending up as "AT&T". That is correct internally within the
package, but when it is XMLified, the current Nmap::Scanner code
is emitting:
<osclass type="media device" vendor="AT&T" osfamily="Windows"
osgen="PocketPC/CE" accuracy="100" />
which is not valid XML.