Skip Menu |

This queue is for tickets about the XML-Parser-Lite-Tree CPAN distribution.

Report information
The Basics
Id: 64338
Status: resolved
Priority: 0/
Queue: XML-Parser-Lite-Tree

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.12
Fixed in: (no value)



Subject: Bleadperl v5.13.7-297-g558b442 breaks X:P:L:T 0.12
While watching cpantesters results I discovered yet another victim of the bugfix in bleadperl v5.13.7-297-g558b442. http://www.mail-archive.com/perl5-changes@perl.org/msg26827.html https://rt.perl.org/rt3//Public/Bug/Display.html?id=80514 https://rt.perl.org/rt3//Public/Bug/Display.html?id=66104 Other modules affected are SOAP::Lite 0.712 and Perl6-Perldoc v0.0.5 HTH, Regards,
On 2010-12-30 09:07:58, ANDK wrote: Show quoted text
> While watching cpantesters results I discovered yet another victim of > the bugfix in bleadperl v5.13.7-297-g558b442. > > http://www.mail-archive.com/perl5-changes@perl.org/msg26827.html > > https://rt.perl.org/rt3//Public/Bug/Display.html?id=80514 > > https://rt.perl.org/rt3//Public/Bug/Display.html?id=66104 > > Other modules affected are SOAP::Lite 0.712 and Perl6-Perldoc v0.0.5
The attached patch makes the test suite pass again with perl 5.14.0 RC0. By setting the return value in the ?{...} constructs explicitely to "undef" the special $^R variable does not have anymore the value "1", causing the array ref problems. But I still don't know if the bleadperl change is accidental or intentional. Regards, Slaven
Subject: XML-Parser-Lite-Tree-0.12-SREZIC-01.patch
From 01116d61c64f47ea48953daafd22a543761a7ae4 Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Sun, 3 Apr 2011 19:29:44 +0200 Subject: [PATCH] * make sure $^R stays undefined --- lib/XML/Parser/LiteCopy.pm | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/XML/Parser/LiteCopy.pm b/lib/XML/Parser/LiteCopy.pm index 8fad1e1..806fc15 100644 --- a/lib/XML/Parser/LiteCopy.pm +++ b/lib/XML/Parser/LiteCopy.pm @@ -100,17 +100,17 @@ sub _regexp { my $DeclCE = "--(?:$CommentCE)?|\\[CDATA\\[(?:$CDATA_CE)?|DOCTYPE(?:$DocTypeCE)?"; - my $PI_CE = "($Name(?:$PI_Tail))>(?{${package}::_pi(\$5)})"; + my $PI_CE = "($Name(?:$PI_Tail))>(?{${package}::_pi(\$5); undef})"; # these expressions were modified for backtracking and events - my $EndTagCE = "($Name)(?{${package}::_end(\$6)})(?:$S)?>"; + my $EndTagCE = "($Name)(?{${package}::_end(\$6); undef})(?:$S)?>"; my $AttValSE = "\"([^<\"]*)\"|'([^<']*)'"; my $ElemTagCE = "($Name)" . "(?:$S($Name)(?:$S)?=(?:$S)?(?:$AttValSE)" . "(?{[\@{\$^R||[]},\$8=>defined\$9?\$9:\$10]}))*(?:$S)?(/)?>" - . "(?{${package}::_start(\$7,\@{\$^R||[]}),\$^R=[]})(?{\$11 and ${package}::_end(\$7)})"; + . "(?{${package}::_start(\$7,\@{\$^R||[]}),\$^R=[]})(?{\$11 and ${package}::_end(\$7); undef})"; my $MarkupSPE = "<(?:!(?:$DeclCE)?|\\?(?:$PI_CE)?|/(?:$EndTagCE)?|(?:$ElemTagCE)?)"; -- 1.7.0.4
patch applied, on cpan as 0.14. tests pass in 5.6.2, 5.8.[1,2,3,6,8,9], 5.10.[0,1]