Skip Menu |

This queue is for tickets about the Log-Log4perl CPAN distribution.

Report information
The Basics
Id: 64318
Status: resolved
Priority: 0/
Queue: Log-Log4perl

People
Owner: Nobody in particular
Requestors: andrew-rt.cpan.org [...] pileofstuff.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Suggested text for 'threshold' error in L4P::Config
Date: Thu, 30 Dec 2010 03:40:24 +0000
To: bug-Log-Log4perl [...] rt.cpan.org
From: Andrew Sayers <andrew-rt.cpan.org [...] pileofstuff.org>
I just tripped over this error message: threshold keyword needs to be uppercase at /usr/share/perl5/Log/Log4perl/Config.pm line 465. Thanks for providing this message - it saved me a lot of head-scratching. I found the exact text a bit confusing though. My first thought was that I had written "warn" instead of "WARN", and my next thought was that I should write "THRESHOLD" instead of "threshold". After a bit of Googling, I realised that I was supposed to use the capital case "Threshold". Could I suggest a message like: invalid keyword 'threshold' - perhaps you meant 'Threshold'? at /usr/share/perl5/Log/Log4perl/Config.pm line 465.
Your message is way better, it's fixed now! https://github.com/mschilli/log4perl/commit/8082e8e4f61c85f67ee0908ab7709d45cbc98c1a Thanks for your contribution. -- Mike