Bug #64310 for Dist-Zilla-Plugins-CJM: gitvercheck.t failure prevents installing Dist::Zilla::Plugin::VersionFromModule

On Wed Dec 29 15:48:01 2010, CJM wrote: Show quoted text
Yes, I did so. Show quoted text
reproduce Show quoted text
STDOUT Show quoted text
Show quoted text
Running look for module 'Dist::Zilla::Plugin::VersionFromModule' Trying to open a subshell in the build directory... CPAN: YAML::XS loaded ok (v0.34) CPAN: Digest::SHA loaded ok (v5.50) CPAN: Compress::Zlib loaded ok (v2.03) Checksum for /home/mike/.cpan/sources/authors/id/C/CJ/CJM/Dist-Zilla- Plugins-CJM-3.04.tar.gz ok Scanning cache /home/mike/.cpan/build for sizes ........................................................................ ....DONE CPAN: Archive::Tar loaded ok (v1.74) Dist-Zilla-Plugins-CJM-3.04 Dist-Zilla-Plugins-CJM-3.04/README Dist-Zilla-Plugins-CJM-3.04/Changes Dist-Zilla-Plugins-CJM-3.04/LICENSE Dist-Zilla-Plugins-CJM-3.04/MANIFEST Dist-Zilla-Plugins-CJM-3.04/META.yml Dist-Zilla-Plugins-CJM-3.04/META.json Dist-Zilla-Plugins-CJM-3.04/t Dist-Zilla-Plugins-CJM-3.04/t/arcrel.t Dist-Zilla-Plugins-CJM-3.04/t/vermod.t Dist-Zilla-Plugins-CJM-3.04/Makefile.PL Dist-Zilla-Plugins-CJM-3.04/t/template.t Dist-Zilla-Plugins-CJM-3.04/t/metadata.t Dist-Zilla-Plugins-CJM-3.04/corpus Dist-Zilla-Plugins-CJM-3.04/corpus/README Dist-Zilla-Plugins-CJM-3.04/t/mb_custom.t Dist-Zilla-Plugins-CJM-3.04/t/00-compile.t Dist-Zilla-Plugins-CJM-3.04/t/gitvercheck.t Dist-Zilla-Plugins-CJM-3.04/corpus/DZT Dist-Zilla-Plugins-CJM-3.04/corpus/DZT/README Dist-Zilla-Plugins-CJM-3.04/corpus/DZT/t Dist-Zilla-Plugins-CJM-3.04/corpus/DZT/t/basic.t Dist-Zilla-Plugins-CJM-3.04/Template_strict.patch Dist-Zilla-Plugins-CJM-3.04/corpus/gitvercheck.git Dist-Zilla-Plugins-CJM-3.04/t/release-pod-syntax.t Dist-Zilla-Plugins-CJM-3.04/t/release-pod-coverage.t Dist-Zilla-Plugins-CJM-3.04/corpus/DZT/lib/DZT Dist-Zilla-Plugins-CJM-3.04/corpus/DZT/lib/DZT/Sample.pm Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Role Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Role/ModuleInfo.pm Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin/Metadata.pm Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin/TemplateCJM.pm Dist-Zilla-Plugins-CJM-3.04/corpus/archives Dist-Zilla-Plugins-CJM-3.04/corpus/archives/DZT-Sample-0.01.tar.gz Dist-Zilla-Plugins-CJM-3.04/corpus/archives/DZT-Sample-0.02.tar.gz Dist-Zilla-Plugins-CJM-3.04/corpus/archives/DZT-Sample-0.03.tar.gz Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin/ArchiveRelease.pm Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin/VersionFromModule.pm Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin/GitVersionCheckCJM.pm Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin/ModuleBuild Dist-Zilla-Plugins-CJM-3.04/lib/Dist/Zilla/Plugin/ModuleBuild/Custom.pm CPAN: File::Temp loaded ok (v0.22) Working directory is /home/mike/.cpan/build/Dist-Zilla-Plugins-CJM-3.04- HqtdEH mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$ mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$ ls Changes lib Makefile.PL META.json README Template_strict.patch corpus LICENSE MANIFEST META.yml t mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$ perl Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Dist::Zilla::Plugins::CJM mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$ make cp lib/Dist/Zilla/Plugin/ArchiveRelease.pm blib/lib/Dist/Zilla/Plugin/ArchiveRelease.pm cp lib/Dist/Zilla/Plugin/GitVersionCheckCJM.pm blib/lib/Dist/Zilla/Plugin/GitVersionCheckCJM.pm cp lib/Dist/Zilla/Role/ModuleInfo.pm blib/lib/Dist/Zilla/Role/ModuleInfo.pm cp lib/Dist/Zilla/Plugin/TemplateCJM.pm blib/lib/Dist/Zilla/Plugin/TemplateCJM.pm cp lib/Dist/Zilla/Plugin/VersionFromModule.pm blib/lib/Dist/Zilla/Plugin/VersionFromModule.pm cp lib/Dist/Zilla/Plugin/Metadata.pm blib/lib/Dist/Zilla/Plugin/Metadata.pm cp lib/Dist/Zilla/Plugin/ModuleBuild/Custom.pm blib/lib/Dist/Zilla/Plugin/ModuleBuild/Custom.pm Manifying blib/man3/Dist::Zilla::Plugin::ArchiveRelease.3pm Manifying blib/man3/Dist::Zilla::Plugin::GitVersionCheckCJM.3pm Manifying blib/man3/Dist::Zilla::Role::ModuleInfo.3pm Manifying blib/man3/Dist::Zilla::Plugin::TemplateCJM.3pm Manifying blib/man3/Dist::Zilla::Plugin::ModuleBuild::Custom.3pm Manifying blib/man3/Dist::Zilla::Plugin::Metadata.3pm Manifying blib/man3/Dist::Zilla::Plugin::VersionFromModule.3pm mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-compile.t ............ # Testing Dist-Zilla-Plugins-CJM 3.04 t/00-compile.t ............ ok t/arcrel.t ................ ok t/gitvercheck.t ........... 1/18 # Failed test 'build 0.04' # at t/gitvercheck.t line 115. # got: 'Stopped because of errors # ' # expected: undef # Failed test 'no errors in 0.04' # at t/gitvercheck.t line 116. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist # Failed test 'errors in modified 0.04' # at t/gitvercheck.t line 127. # Structures begin differing at: # $got->{Sample} = 'dist version 0.04 needs to be updated' # $expected->{Sample} = Does not exist # Failed test 'errors in 0.05' # at t/gitvercheck.t line 138. # Structures begin differing at: # $got->{First} = '0.03 needs to be updated' # $expected->{First} = Does not exist # Failed test 'can build 0.05 now' # at t/gitvercheck.t line 147. # got: 'Stopped because of errors # ' # expected: undef # Failed test 'no errors in 0.05 now' # at t/gitvercheck.t line 148. # Structures begin differing at: # $got->{First} = '0.03 needs to be updated' # $expected->{First} = Does not exist # Failed test 'errors with 0.045' # at t/gitvercheck.t line 159. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist # Failed test 'errors in 0.05 with 0.045' # at t/gitvercheck.t line 168. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist t/gitvercheck.t ........... 13/18 # Failed test 'errors in 0.05 with 0.045 committed' # at t/gitvercheck.t line 180. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist # Failed test 'can build with First 0.05' # at t/gitvercheck.t line 189. # got: 'Stopped because of errors # ' # expected: undef # Failed test 'no errors with First 0.05' # at t/gitvercheck.t line 190. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist # Looks like you failed 11 tests of 18. t/gitvercheck.t ........... Dubious, test returned 11 (wstat 2816, 0xb00) Failed 11/18 subtests t/mb_custom.t ............. ok t/metadata.t .............. ok t/release-pod-coverage.t .. skipped: these tests are for release candidate testing t/release-pod-syntax.t .... skipped: these tests are for release candidate testing t/template.t .............. ok t/vermod.t ................ ok Test Summary Report ------------------- t/gitvercheck.t (Wstat: 2816 Tests: 18 Failed: 11) Failed tests: 1-2, 4, 6-8, 10, 12, 14-16 Non-zero exit status: 11 Files=9, Tests=46, 9 wallclock secs ( 0.07 usr 0.01 sys + 8.57 cusr 0.86 csys = 9.51 CPU) Result: FAIL Failed 1/9 test programs. 11/46 subtests failed. make: *** [test_dynamic] Error 255 mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$ git -- version git version 1.7.0.4 mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$ perl -V Summary of my perl5 (revision 5 version 10 subversion 1) configuration: Platform: osname=linux, osvers=2.6.24-27-server, archname=x86_64-linux-gnu- thread-multi uname='linux crested 2.6.24-27-server #1 smp fri mar 12 01:23:09 utc 2010 x86_64 gnulinux ' config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN - Dcccdlflags=-fPIC -Darchname=x86_64-linux-gnu -Dprefix=/usr - Dprivlib=/usr/share/perl/5.10 -Darchlib=/usr/lib/perl/5.10 - Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 - Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local - Dsitelib=/usr/local/share/perl/5.10.1 - Dsitearch=/usr/local/lib/perl/5.10.1 -Dman1dir=/usr/share/man/man1 - Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 - Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1 -Dman3ext=3perl - Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio - Uusenm -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib - Dlibperl=libperl.so.5.10.1 -Dd_dosuid -des' hint=recommended, useposix=true, d_sigaction=define useithreads=define, usemultiplicity=define useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=define, use64bitall=define, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict- aliasing -pipe -fstack-protector -I/usr/local/include - D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2 -g', cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing - pipe -fstack-protector -I/usr/local/include' ccversion='', gccversion='4.4.3', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='cc', ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib /lib64 /usr/lib64 libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=/lib/libc-2.11.1.so, so=so, useshrplib=true, libperl=libperl.so.5.10.1 gnulibc_version='2.11.1' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib - fstack-protector' Characteristics of this binary (from libperl): Compile-time options: MULTIPLICITY PERL_DONT_CREATE_GVSV PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP USE_64_BIT_ALL USE_64_BIT_INT USE_ITHREADS USE_LARGE_FILES USE_PERLIO USE_REENTRANT_API Built under linux Compiled at Apr 23 2010 08:21:31 %ENV: PERL5LIB="" PERL5OPT="" PERL5_CPANPLUS_IS_RUNNING="15544" PERL5_CPAN_IS_RUNNING="15544" @INC: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl . mike@charron:~/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-HqtdEH$

$ perl -Ilib t/gitvercheck.t 1..18 not ok 1 - build 0.04 # Failed test 'build 0.04' # at t/gitvercheck.t line 115. # got: 'Stopped because of errors # ' # expected: undef not ok 2 - no errors in 0.04 # Failed test 'no errors in 0.04' # at t/gitvercheck.t line 116. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist [DZ] beginning to build DZT-Sample [DZ] guessing dist's main_module is lib/DZT/Sample.pm [VersionFromModule] dist version 0.04 (from lib/DZT/Sample.pm) [GitVersionCheckCJM] ERROR: lib/DZT/First.pm: 0.03 needs to be updated [GitVersionCheckCJM] ERROR: lib/DZT/Sample/Second.pm: 0.03 needs to be updated [GitVersionCheckCJM] ERROR: lib/DZT/Sample.pm: dist version 0.04 needs to be updated /home/mike/.cpan/build/Dist-Zilla-Plugins-CJM-3.04-wiRv7K/tmp/bg33hqFntG ok 3 - can't build modified 0.04 not ok 4 - errors in modified 0.04 # Failed test 'errors in modified 0.04' # at t/gitvercheck.t line 127. # Structures begin differing at: # $got->{Sample} = 'dist version 0.04 needs to be updated' # $expected->{Sample} = Does not exist ok 5 - can't build 0.05 yet not ok 6 - errors in 0.05 # Failed test 'errors in 0.05' # at t/gitvercheck.t line 138. # Structures begin differing at: # $got->{First} = '0.03 needs to be updated' # $expected->{First} = Does not exist not ok 7 - can build 0.05 now # Failed test 'can build 0.05 now' # at t/gitvercheck.t line 147. # got: 'Stopped because of errors # ' # expected: undef not ok 8 - no errors in 0.05 now # Failed test 'no errors in 0.05 now' # at t/gitvercheck.t line 148. # Structures begin differing at: # $got->{First} = '0.03 needs to be updated' # $expected->{First} = Does not exist ok 9 - can't build with 0.045 not ok 10 - errors with 0.045 # Failed test 'errors with 0.045' # at t/gitvercheck.t line 159. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist ok 11 - can't build 0.05 with 0.045 not ok 12 - errors in 0.05 with 0.045 # Failed test 'errors in 0.05 with 0.045' # at t/gitvercheck.t line 168. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist ok 13 - can't build 0.05 with 0.045 committed not ok 14 - errors in 0.05 with 0.045 committed # Failed test 'errors in 0.05 with 0.045 committed' # at t/gitvercheck.t line 180. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist not ok 15 - can build with First 0.05 # Failed test 'can build with First 0.05' # at t/gitvercheck.t line 189. # got: 'Stopped because of errors # ' # expected: undef not ok 16 - no errors with First 0.05 # Failed test 'no errors with First 0.05' # at t/gitvercheck.t line 190. # Structures begin differing at: # $got->{Sample/Second} = '0.03 needs to be updated' # $expected->{Sample/Second} = Does not exist ok 17 - can't build with First unversioned ok 18 - errors with First unversioned # Looks like you failed 11 tests of 18.

From the log messages, it appears that git thinks files have been modified that shouldn't be modified. When it pauses, cd to the source directory under the tempdir it reports, and run "git status". It should say: $ git status # On branch master nothing to commit (working directory clean) If it doesn't, please try to figure out what it thinks needs to be committed, and why. Thanks again for your help debugging this.

ditto for me on everything in this ticket (except that I'm tring to get ArchiveRelease installed). git version 1.7.0.4 Summary of my perl5 (revision 5 version 10 subversion 1) configuration: Platform: osname=linux, osvers=2.6.24-27-server, archname=i486-linux-gnu-thread-multi uname='linux vernadsky 2.6.24-27-server #1 smp fri mar 12 01:45:06 utc 2010 i686 gnulinux ' config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=i486-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.10 -Darchlib=/usr/lib/perl/5.10 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.10.1 -Dsitearch=/usr/local/lib/perl/5.10.1 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Ud_ualarm -Uusesfio -Uusenm -DDEBUGGING=-g -Doptimize=-O2 -Duseshrplib -Dlibperl=libperl.so.5.10.1 -Dd_dosuid -des' hint=recommended, useposix=true, d_sigaction=define useithreads=define, usemultiplicity=define useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=undef, use64bitall=undef, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2 -g', cppflags='-D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include' ccversion='', gccversion='4.4.3', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, prototype=define Linker and Libraries: ld='cc', ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib /usr/lib64 libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=/lib/libc-2.11.1.so, so=so, useshrplib=true, libperl=libperl.so.5.10.1 gnulibc_version='2.11.1' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector' Characteristics of this binary (from libperl): Compile-time options: MULTIPLICITY PERL_DONT_CREATE_GVSV PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP USE_ITHREADS USE_LARGE_FILES USE_PERLIO USE_REENTRANT_API Built under linux Compiled at Apr 23 2010 07:36:53 %ENV: PERL5LIB="/home/rando/perl5/lib/perl5/i486-linux-gnu-thread-multi:/home/rando/perl5/lib/perl5" @INC: /home/rando/perl5/lib/perl5/i486-linux-gnu-thread-multi /home/rando/perl5/lib/perl5/i486-linux-gnu-thread-multi /home/rando/perl5/lib/perl5 /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .

I think this is fixed in Dist-Zilla-Plugins-CJM-4.02. I was finally able to reproduce it after installing FreeBSD 8.1 in a VM and downgrading git to 1.7.0.4. It seems that in some versions of git (1.7.0.4 in particular), "git diff-index" could report modified files even though "git status" would not (and the files were not actually modified). Doing "git reset --mixed" seems to correct this. Please try Dist-Zilla-Plugins-CJM-4.02 (just uploaded to CPAN; should be available soon) and see if the tests pass now.