Bug #6419 for POE: dubious use of skip in t\30_filter

Tue May 25 21:16:08 2004 Guest - Ticket created

Subject:

dubious use of skip in t\30_filter_httpd.t

at line 125, I don't know what this is supposed to be if (0 and $^O eq "MSWin32" and $] < 5.008003) { skip("Please upgrade ActivePerl to pass this test."); } else { is($req->content, "I=like&tasty=pie\n", 'simple post: HTTP::Request object contains proper content'); } but it's just plain wrong. On perl 5.6.1 it dies with ok 31 - simple post: HTTP::Request object contains proper URI skip() needs to know $how_many tests are in the block at t/30_filter_httpd.t line 125 ok 32 # skip Please upgrade ActivePerl to pass this test. Label not found for "last SKIP" at C:/perl/site/lib/Test/More.pm line 813. # Looks like you planned 56 tests but only ran 32. Changing the if line to if (0 and $^O eq "MSWin32" and $] < 5.008003) { and running the test gives All tests successful, 7 subtests skipped. Seems to me like you should be testing for an appropriate version of HTTP::Request, not perl. Its easy to upgrade modules

Wed May 26 00:00:51 2004 RCAPUTO [...] cpan.org - Correspondence added

Thank you, mystery bug reporter! You may not ever see this response, though, because you didn't include an e-mail address where ticket statuses could be posted. Nevertheless, thanks to your conscientious bug reporting I have applied the following change to t/ 30_filter_httpd.t: - if ($^O eq "MSWin32" and $] < 5.008003) { - skip("Please upgrade ActivePerl to pass this test."); - } - else { + # The HTTP::Request bundled with ActivePerl 5.6.1 causes a test + # failure here. The one included in ActivePerl 5.8.3 works fine. + # It was suggested by an anonymous bug reporter to test against + # HTTP::Request's version rather than Perl's, so we're doing that + # here. Theoretically we shouldn't get this far. The Makefile + # magic should strongly suggest HTTP::Request 1.34. But people + # install (or fail to) the darnedest things, so I thought it was + # safe to check here rather than fail the test due to operator + # error. + SKIP: { + my $required_http_request_version = 1.34; + skip("simple post: Please upgrade HTTP::Request to $required_http_request_version or later", 1) + if $^O eq "MSWin32" and $HTTP::Request::VERSION < $required_http_request_version; + Apologies for any newline breakage. The RT web interface seems to introduce it. -- Rocco Caputo

Wed May 26 00:01:20 2004 RCAPUTO [...] cpan.org - Correspondence added

Thank you, mystery bug reporter! You may not ever see this response, though, because you didn't include an e-mail address where ticket statuses could be posted. Nevertheless, thanks to your conscientious bug reporting I have applied the following change to t/ 30_filter_httpd.t: - if ($^O eq "MSWin32" and $] < 5.008003) { - skip("Please upgrade ActivePerl to pass this test."); - } - else { + # The HTTP::Request bundled with ActivePerl 5.6.1 causes a test + # failure here. The one included in ActivePerl 5.8.3 works fine. + # It was suggested by an anonymous bug reporter to test against + # HTTP::Request's version rather than Perl's, so we're doing that + # here. Theoretically we shouldn't get this far. The Makefile + # magic should strongly suggest HTTP::Request 1.34. But people + # install (or fail to) the darnedest things, so I thought it was + # safe to check here rather than fail the test due to operator + # error. + SKIP: { + my $required_http_request_version = 1.34; + skip("simple post: Please upgrade HTTP::Request to $required_http_request_version or later", 1) + if $^O eq "MSWin32" and $HTTP::Request::VERSION < $required_http_request_version; + Apologies for any newline breakage. The RT web interface seems to introduce it. -- Rocco Caputo

Wed May 26 00:01:25 2004 RCAPUTO [...] cpan.org - Status changed from 'new' to 'resolved'

Bug #6419 for POE: dubious use of skip in t\30_filter_httpd.t