Bug #64177 for DBD-SQLite: ping() wipes out the errstr

Thu Dec 23 10:59:05 2010 VLYON [...] cpan.org - Ticket created

Subject:

ping() wipes out the errstr

According to DBI the ping() method won't affect the errstr from a previous error. http://search.cpan.org/perldoc?DBI#err However in DBD::SQLite it wipes it out and sets the errstr to undef! Diff to test for it: Index: DBD-SQLite/t/07_error.t =================================================================== --- DBD-SQLite/t/07_error.t (revision 13493) +++ DBD-SQLite/t/07_error.t (working copy) @@ -7,7 +7,7 @@ } use t::lib::Test; -use Test::More tests => 8; +use Test::More tests => 9; use Test::NoWarnings; my $dbh = connect_ok( RaiseError => 1, PrintError => 0 ); @@ -18,6 +18,9 @@ is( $DBI::err, 1, '$DBI::err ok' ); is( $DBI::errstr, 'near "ssdfsdf": syntax error', '$DBI::errstr ok' ); +$dbh->ping; # ping() should not clear the errstr! +is $dbh->errstr, 'near "ssdfsdf": syntax error', '$dbh->ping does not clear the error'; + $dbh->do('create table testerror (a, b)'); $dbh->do('insert into testerror values (1, 2)'); $dbh->do('insert into testerror values (3, 4)');

Fri Dec 24 00:56:42 2010 ishigaki [...] cpan.org - Correspondence added

Well, actually DBD::SQLite does nothing about "ping". The method is from DBI, and it somehow does not do the right thing (the same thing happens when you use DBD::Sponge). Could you report this to the DBI's tracker? Thanks, Kenichi On Thu Dec 23 10:59:05 2010, VLYON wrote: Show quoted text

> According to DBI the ping() method won't affect the errstr from a > previous error. > http://search.cpan.org/perldoc?DBI#err > > However in DBD::SQLite it wipes it out and sets the errstr to undef! > > Diff to test for it: > > Index: DBD-SQLite/t/07_error.t > =================================================================== > --- DBD-SQLite/t/07_error.t (revision 13493) > +++ DBD-SQLite/t/07_error.t (working copy) > @@ -7,7 +7,7 @@ > } > > use t::lib::Test; > -use Test::More tests => 8; > +use Test::More tests => 9; > use Test::NoWarnings; > > my $dbh = connect_ok( RaiseError => 1, PrintError => 0 ); > @@ -18,6 +18,9 @@ > is( $DBI::err, 1, '$DBI::err ok' ); > is( $DBI::errstr, 'near "ssdfsdf": syntax error', '$DBI::errstr

ok' ); Show quoted text

> > +$dbh->ping; # ping() should not clear the errstr! > +is $dbh->errstr, 'near "ssdfsdf": syntax error', '$dbh->ping does not > clear the error'; > + > $dbh->do('create table testerror (a, b)'); > $dbh->do('insert into testerror values (1, 2)'); > $dbh->do('insert into testerror values (3, 4)');

Fri Dec 24 00:56:43 2010 The RT System itself - Status changed from 'new' to 'open'

Thu Dec 30 06:41:49 2010 VLYON [...] cpan.org - Reference to ticket #64330 added

Thu Sep 06 10:48:13 2012 ishigaki [...] cpan.org - Correspondence added

Implemented ping() in the trunk and the issue seems to be gone. Thanks. On Fri Dec 24 14:56:42 2010, ISHIGAKI wrote: Show quoted text

> Well, actually DBD::SQLite does nothing about "ping". The method is > from DBI, and it somehow does not do the right thing (the same thing > happens when you use DBD::Sponge). Could you report this to the DBI's > tracker? > > Thanks, > > Kenichi > > On Thu Dec 23 10:59:05 2010, VLYON wrote:

> > According to DBI the ping() method won't affect the errstr from a > > previous error. > > http://search.cpan.org/perldoc?DBI#err > > > > However in DBD::SQLite it wipes it out and sets the errstr to undef! > > > > Diff to test for it: > > > > Index: DBD-SQLite/t/07_error.t > > =================================================================== > > --- DBD-SQLite/t/07_error.t (revision 13493) > > +++ DBD-SQLite/t/07_error.t (working copy) > > @@ -7,7 +7,7 @@ > > } > > > > use t::lib::Test; > > -use Test::More tests => 8; > > +use Test::More tests => 9; > > use Test::NoWarnings; > > > > my $dbh = connect_ok( RaiseError => 1, PrintError => 0 ); > > @@ -18,6 +18,9 @@ > > is( $DBI::err, 1, '$DBI::err ok' ); > > is( $DBI::errstr, 'near "ssdfsdf": syntax error', '$DBI::errstr

> ok' );

> > > > +$dbh->ping; # ping() should not clear the errstr! > > +is $dbh->errstr, 'near "ssdfsdf": syntax error', '$dbh->ping does

not Show quoted text

> > clear the error'; > > + > > $dbh->do('create table testerror (a, b)'); > > $dbh->do('insert into testerror values (1, 2)'); > > $dbh->do('insert into testerror values (3, 4)');

> >

Thu Sep 06 10:48:14 2012 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Mon Sep 10 10:07:30 2012 VLYON [...] cpan.org - Status changed from 'patched' to 'resolved'