Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 64146
Status: resolved
Priority: 0/
Queue: Net-DNS

People
Owner: Nobody in particular
Requestors: WolfSage [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.66
Fixed in: (no value)



Subject: Net::DNS::RR::Key has wrong inheritence, $rr->print doesn't work
The Net::DNS::RR::Key class was changed in .66 to be a subclass of Net::DNS::RR::DNSKEY. With this change, the Net::DNS::RR::Key objects have been broken. Take the following code for example: my $rr = Net::DNS::RR->new('zone.com IN KEY 256 3 5 AwEA'); $rr->print; This prints: zone.com. 0 IN KEY ; rdlength = 0 When it should print: zone.com. 0 IN KEY 256 3 5 ( AwEA ) ; Key ID = 1798 It looks like the problem is the inheritance order for the Net::DNS::RR::Key object. Its @ISA looks like this: @ISA = qw(Net::DNS::RR Net::DNS::RR::DNSKEY); When it should really look like this: @ISA = qw(Net::DNS::RR::DNSKEY Net::DNS::RR); After changing it around and rerunning the above perl code, I get the correct output. Tested on Perl v5.8.9
Hi WolfSage, You are correct. Also since Net::DNS::RR is already a base class of Net::DNS::RR::DNSKEY, there is no reason why it should also be a base class of Net::DNS::RR::KEY. Net::DNS::RR may simply be removed from the @ISA list. The change is committed (including test script 18-keyprint.t). Regards, Willem
On Mon Jan 17 05:59:20 2011, WILLEM wrote: Show quoted text
> Hi WolfSage, > > You are correct. Also since Net::DNS::RR is already a base class of > Net::DNS::RR::DNSKEY, there is no reason why it should also be a base > class of Net::DNS::RR::KEY. Net::DNS::RR may simply be removed from the > @ISA list. > > The change is committed (including test script 18-keyprint.t). > > Regards, Willem
Willem, the broken version is still the latest in CPAN. Would it be possible to cut a new release soon?
Hi Matthew, Next week I will create a release candidate which will be thoroughly tested on as many different systems possible (and hopefully by the package maintainers for Net::DNS). The week after that, the 0.67 release will follow. It is my intention to release more frequently thereafter. Regards, Willem On Thu Oct 20 11:33:05 2011, WOLFSAGE wrote: Show quoted text
> On Mon Jan 17 05:59:20 2011, WILLEM wrote:
> > Hi WolfSage, > > > > You are correct. Also since Net::DNS::RR is already a base class of > > Net::DNS::RR::DNSKEY, there is no reason why it should also be a base > > class of Net::DNS::RR::KEY. Net::DNS::RR may simply be removed from the > > @ISA list. > > > > The change is committed (including test script 18-keyprint.t). > > > > Regards, Willem
> > Willem, the broken version is still the latest in CPAN. Would it be > possible to cut a new release soon?