Bug #63990 for POE-Component-Client-HTTP: wrong header Host, when redirect is relative

Thu Dec 16 13:00:18 2010 kozunov [...] gmail.com - Ticket created

Subject:

wrong header Host, when redirect is relative

I create a request $url = 123.123.123.123;#ip my $r = HTTP::Request->new( 'GET', $url, [Host => 'myho.st']); and recieve response HTTP/1.1 302 Found Location: /some/path/ then Client-HTTP create a request GET /some/path/ HTTP/1.1 Host: 123.123.123.123 but this is wrong I've patched sub check_redirect my $new_uri = $self->[REQ_RESPONSE]->header ('Location'); my $new_uri_save = $new_uri; #add this string #change header Host only if redirect is absolute if ($new_uri eq $new_uri_save) { #add this string DEBUG and warn "RED: redirect abs"; #add this string _set_host_header ($newrequest); #add this string } else { #add this string DEBUG and warn "RED: redirect relative"; #add this string } #add this string #_set_host_header ($newrequest); #delete this string

Wed Jan 26 23:46:20 2011 RCAPUTO [...] cpan.org - Correspondence added

I'm applying a slightly different patch. Apparently $new_uri->scheme() will be undef for a relative Location. That should be enough to detect the relative redirect, so I've eliminated $new_uri_save. Now... I need a site that responds with a relative redirect for testing. Would you happen to know one offhand? Thanks! On Thu Dec 16 13:00:18 2010, sergei wrote: Show quoted text

> I create a request > > $url = 123.123.123.123;#ip > my $r = HTTP::Request->new( 'GET', $url, [Host => 'myho.st']); > > and recieve response > HTTP/1.1 302 Found > Location: /some/path/ > > then Client-HTTP create a request > GET /some/path/ HTTP/1.1 > Host: 123.123.123.123 > > but this is wrong > > > I've patched sub check_redirect > > my $new_uri = $self->[REQ_RESPONSE]->header ('Location'); > my $new_uri_save = $new_uri; #add this string > > > #change header Host only if redirect is absolute > if ($new_uri eq $new_uri_save) { #add this string > DEBUG and warn "RED: redirect abs"; #add this string > _set_host_header ($newrequest); #add this string > } else { #add this string > DEBUG and warn "RED: redirect relative"; #add this string > } #add this string > #_set_host_header ($newrequest); #delete this string >

Wed Jan 26 23:46:22 2011 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 27 04:33:21 2011 kozunov [...] gmail.com - Correspondence added

From:

kozunov [...] gmail.com

Thank you for resolved my problems. This is domain http://pdd.yandex.ru make relative redirect. Срд Янв 26 23:46:20 2011, RCAPUTO писал: Show quoted text

> I'm applying a slightly different patch. Apparently $new_uri->scheme() > will be undef for a relative Location. That should be enough to detect > the relative redirect, so I've eliminated $new_uri_save. > > Now... I need a site that responds with a relative redirect for testing. > Would you happen to know one offhand? > > Thanks! > > On Thu Dec 16 13:00:18 2010, sergei wrote:

> > I create a request > > > > $url = 123.123.123.123;#ip > > my $r = HTTP::Request->new( 'GET', $url, [Host => 'myho.st']); > > > > and recieve response > > HTTP/1.1 302 Found > > Location: /some/path/ > > > > then Client-HTTP create a request > > GET /some/path/ HTTP/1.1 > > Host: 123.123.123.123 > > > > but this is wrong > > > > > > I've patched sub check_redirect > > > > my $new_uri = $self->[REQ_RESPONSE]->header ('Location'); > > my $new_uri_save = $new_uri; #add this string > > > > > > #change header Host only if redirect is absolute > > if ($new_uri eq $new_uri_save) { #add this string > > DEBUG and warn "RED: redirect abs"; #add this string > > _set_host_header ($newrequest); #add this string > > } else { #add this string > > DEBUG and warn "RED: redirect relative"; #add this string > > } #add this string > > #_set_host_header ($newrequest); #delete this string > >

> >

Thu Jan 27 18:29:35 2011 RCAPUTO [...] cpan.org - Correspondence added

http://pdd.yandex.ru seems to work now. Thank you for the help!

Thu Jan 27 18:29:36 2011 RCAPUTO [...] cpan.org - Status changed from 'open' to 'resolved'