Skip Menu |

This queue is for tickets about the Class-XSAccessor CPAN distribution.

Report information
The Basics
Id: 63981
Status: resolved
Priority: 0/
Queue: Class-XSAccessor

People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc: david [...] cantrell.org.uk
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: david [...] cantrell.org.uk
Subject: Another segfault :(
I actually have never seen it happen myself, but figured I'll open a bug so that it can be properly investigated. This smoker failure is clearly a segfault: http://www.cpantesters.org/cpan/report/5afd8e2e-0527-11e0-98cd-e437adc8c11d. I am CC-ing David Cantrell on this bug, hopefully he can provide more info wrt reproducibility of this issue. Other than that smoke results seem quite stellar :)
RT-Send-CC: david [...] cantrell.org.uk
On Thu Dec 16 04:46:41 2010, RIBASUSHI wrote: Show quoted text
> I actually have never seen it happen myself, but figured I'll open a bug > so that it can be properly investigated. This smoker failure is clearly > a segfault: > http://www.cpantesters.org/cpan/report/5afd8e2e-0527-11e0-98cd-e437adc8c11d. > > I am CC-ing David Cantrell on this bug, hopefully he can provide more > info wrt reproducibility of this issue. > > Other than that smoke results seem quite stellar :)
Ooooh. I usually try to be civil in public and archived conversations (only there, of course), but fuck! NOT again. And it always happens in ways that are hard to reproduce! Either way, thanks for filing the ticket (and thanks to David for the smoke). I'm not sure how to proceed, though. I suspect that the thing might not even fail ALL the time for David, depending on the load of the system. Sadly, I don't currently have the time and resources to try to reproduce and fix the issue. *Maybe* I could get somewhere with a stack trace, but given that threads are involved, that's not a given either. Best regards, Steffen
I think I told everyone involved by email a while ago. This is just for the record: David kindly provided me with access to the box where the crashes are happening. I managed to reproduce the crash, but it is very rare. I did not manage (in the time I could spend on it) to reproduce the crash in gdb. So this is back to blocked. Best regards, Steffen
Sadly, there has been another CPAN testers report failing the thread bomb stress test. This time cygwin. http://www.cpantesters.org/cpan/report/e7386d97-6c92-1014-9d85-393306c0976e Gah. I need magic pixie dust and a bucket of brains to get to the bottom of this at some point. --Steffen
Subject: Re: [rt.cpan.org #63981] Another segfault :(
Date: Mon, 24 Jan 2011 13:54:32 +0000
To: bug-Class-XSAccessor [...] rt.cpan.org
From: chocolateboy <chocolateboy [...] chocolatey.com>
I'll try to take a look next time I fire up XP/Windows 7 in VirtualBox. FWIW, I have /way/ more failures with /most/ of my CPAN modules than we have with Class::XSAccessor. I salute your diligence, but I (personally) don't think J Random OS failing/segfaulting occasionally is a big deal. To paraphrase someone whose name I've forgotten: if your modules aren't segfaulting on a regular basis, then you're not attempting to do anything interesting. Surely you must be used to this with PAR? I'm sure even I've filed some bogus bug reports against that. :-) On 24/01/11 13:34, Steffen Mueller via RT wrote: Show quoted text
> Queue: Class-XSAccessor > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=63981> > > Sadly, there has been another CPAN testers report failing the thread > bomb stress test. This time cygwin. > > http://www.cpantesters.org/cpan/report/e7386d97-6c92-1014-9d85-393306c0976e > > Gah. I need magic pixie dust and a bucket of brains to get to the bottom > of this at some point. > > --Steffen > >
Subject: Re: [rt.cpan.org #63981] Another segfault :(
Date: Mon, 24 Jan 2011 16:09:27 +0100
To: bug-Class-XSAccessor [...] rt.cpan.org
From: Steffen Mueller <smueller [...] cpan.org>
Hi Chocolateboy, On 01/24/2011 02:54 PM, chocolateboy via RT wrote: Show quoted text
> Queue: Class-XSAccessor > Ticket<URL: https://rt.cpan.org/Ticket/Display.html?id=63981> > > I'll try to take a look next time I fire up XP/Windows 7 in VirtualBox.
Awesome, thank you! Show quoted text
> FWIW, I have /way/ more failures with /most/ of my CPAN modules than we > have with Class::XSAccessor. I salute your diligence, but I (personally) > don't think J Random OS failing/segfaulting occasionally is a big deal. > To paraphrase someone whose name I've forgotten: if your modules aren't > segfaulting on a regular basis, then you're not attempting to do > anything interesting. > > Surely you must be used to this with PAR? I'm sure even I've filed some > bogus bug reports against that. :-)
Yes, trying to make/keep PAR/PAR::Packer portable and robust has cost me plenty of hair due to frustration. I am very, very happy that the ever helpful and industrious Roderich Schupp has taken it off my hands when I was about to give up. That reminds me that I should take a step back and now support HIS work in turn. Alas, still swamped. The difference to PAR is that PAR is a development tool. PAR.pm can't segfault, but if PAR::Packer does... so what? A frustrated developer? What do I care? Let's share the hate. C::XSA is, however, very widely used in diverse environments, some of them persistent (mod_perl with threading and friends) and critical. I know that Peter, who reported this crash, added code to use C::XSA to Class::Accessor::Grouped which is used by, correct me if I am wrong, DBIx::Class. Rose::Object uses C::XSA if available. I also believe Matt Trout's Moo.pm uses it optionally. Given that these are all infrastructural modules themselves, the number of upstream dependents can be very large. Additionally, I know of at least one proprietary large product that uses it. No. Not my employer. This all considered, I admit that this turned into a petty rant instead of a tongue-in-cheek response. Sorry if I went all lecturer on you ;) But seriously, I think making C::XSA robust isn't just a fun exercise at this point. On a related note (but off-topic for this bug report), I managed to make stack-munging method delegation in XS work, but without entersub optimization at this point. It's not that hard after all after understanding the stacks. Turns out it is slower than doing the same in Perl. Probably due to call_sv being slower than entersub. I will be in touch once I find the time to find out what's going on. Cheers, Steffen
On Mon Jan 24 10:09:39 2011, SMUELLER wrote: Show quoted text
> But seriously, I think making C::XSA robust isn't just a fun exercise at > this point. >
Fwiw I'd like to ++ this attitude (even if I can't really add anything to the problem at hand). Awesome software must be awesome :) Thank you Steffen for your work and continuing pursuit of perfection, keep it up!
In case it wasn't clear, my post was a light-hearted attempt to say "chin up" and "don't let the bug reports grind you down", rather than a rousing call to write unstable software :-)
On Thu Dec 16 11:20:15 2010, SMUELLER wrote: Show quoted text
> Either way, thanks for filing the ticket (and thanks to David for the > smoke). I'm not sure how > to proceed, though.
Given the recent fixed in the allocator, and given C::XSA 1.13 had over 150 PASS results on FreeBSD alone (and no fails at all) - I think we can be rather confident this problem has been fixed, and the ticket can be closed. Thanks for the excellent work! Cheers