Bug #63909 for Module-Install-RTx: RT version checking needs to be updated for 4.0

Tue Dec 14 12:36:11 2010 trs [...] bestpractical.com - Ticket created

Subject:	RT version checking needs to be updated for 4.0
Date:	Tue, 14 Dec 2010 12:36:09 -0500
To:	bug-Module-Install-RTx [...] rt.cpan.org
From:	Thomas Sibley <trs [...] bestpractical.com>

The RT version in 4 lives in RT::Generated. We may want a requires_rt('version') function that is clever instead of requires(RT => 'version').

Tue Mar 15 18:59:07 2011 trs [...] bestpractical.com - Correspondence added

Subject:	[rt.cpan.org #63909] Further bugs with version parsing on RT's 4.0/version-shenanigans branch
Date:	Tue, 15 Mar 2011 18:59:05 -0400
To:	bug-Module-Install-RTx [...] rt.cpan.org
From:	Thomas Sibley <trs [...] bestpractical.com>

Steps to reproduce two version comparison bugs using an installed copy of RT's 4.0/version-shenanigans at 4.0.0rc6-13-g325cca6 (with that version string in RT::Generated) and RT-Extension-LDAPImport as of 56c45664c441043d7d8725903930cdd18ace5caf. == Broken Module::AutoInstall version checking 1) Change the requires RT line in Makefile.PL to '4.0.0'. 2) Running perl Makefile.PL doesn't fail despite you having rc6 because the version comparison Module::AutoInstall does is wrong: - RT ...loaded. (4.0.0_6 >= 4.0.0) Note that it does work for 4.0.1. == Broken ExtUtils::MakeMaker (ExtUtils::MM_Unix::parse_version) 1) Leaving the require RT line as '4.0.0' note that MM doesn't issue a warning about an invalid version either because it also does the comparison wrong. Note that it's comparing against the full version string though, not the sanitized one AutoInstall gets. 2) Bump the requires RT version to 4.0.1 and it _still_ fails to detect an invalid dep. 4.0.2, 4.0.3, etc. are the same. 3) Bump the requires RT version to 4.1.0 or 6.0.0 and, finally, it realizes it doesn't have it, warning with: Warning: prerequisite RT 4.1.0 not found. We have 4.0.0rc6-13-g325cca6. after the AutoInstall check and prompt (which should get it right here too). Both of these bugs only crop up when installing against development versions of RT, but we really do want to encourage folks to test our dev releases. I'm not sure this gets fixed for 4.0. trs

Thu Mar 17 10:58:31 2011 trs [...] bestpractical.com - Correspondence added

Subject:	[rt.cpan.org #63909] Yet another bug with ExtUtils::MakeMaker
Date:	Thu, 17 Mar 2011 10:58:29 -0400
To:	bug-Module-Install-RTx [...] rt.cpan.org
From:	Thomas Sibley <trs [...] bestpractical.com>

Even if the version in RT/Generated.pm is '4.0.0' and the Makefile.PL requires 4.0.1, ExtUtils::MakeMaker fails to correctly compare the versions. 4.0.0 is not less than 4.0.1 in it's code, although it's not clear why.