Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 63695
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: djo [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 1.109
  • 1.108
  • 1.111
Fixed in:
  • 1.110_001
  • 1.112_001
  • 1.112_002
  • 1.113

History Show all quoted text
  Tue Dec 07 06:58:19 2010 djo [...] cpan.org - Ticket created
Subject: [Patch] Perl::Critic should require "version" >= 0.77
lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm requires "version" 0.77 BuildUtilities.pm says any version will do which makes the build fail on older perls (e.g. 5.8.8) The attached patch fixes the problem. -- Best regards, David Jack Olrik <david@olrik.dk> http://david.olrik.dk GnuPG fingerprint C290 0A4A 0CCC CBA8 2B37 E18D 01D2 F6EF 2E61 9894 ["The first rule of Perl club is You do not talk about Perl club"]
Subject: Perl-Critic-1.109.patch
diff -NurB Perl-Critic-1.109.orig/inc/Perl/Critic/BuildUtilities.pm Perl-Critic-1.109/inc/Perl/Critic/BuildUtilities.pm --- Perl-Critic-1.109.orig/inc/Perl/Critic/BuildUtilities.pm 2010-08-30 03:59:19.000000000 +0200 +++ Perl-Critic-1.109/inc/Perl/Critic/BuildUtilities.pm 2010-12-06 23:06:46.000000000 +0100 @@ -70,7 +70,7 @@ 'charnames' => 0, 'overload' => 0, 'strict' => 0, - 'version' => 0, + 'version' => 0.77, 'overload' => 0, 'strict' => 0, 'version' => 0,
  Tue Dec 07 07:57:39 2010 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #63695] [Patch] Perl::Critic should require "version" >= 0.77
Date: Tue, 07 Dec 2010 06:57:25 -0600
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Thanks. The fix for this is in the 1.110_001 release. http://search.cpan.org/~elliotjs/Perl-Critic-1.110_001/
  Tue Dec 07 07:57:39 2010 The RT System itself - Status changed from 'new' to 'open'
  Tue Dec 07 10:41:43 2010 wyant [...] cpan.org - Status changed from 'open' to 'patched'
  Tue Dec 07 10:41:55 2010 wyant [...] cpan.org - Fixed in 1.110_001 added
  Tue Jan 04 20:14:13 2011 wyant [...] cpan.org - Broken in 1.108 added
  Tue Jan 04 20:14:13 2011 wyant [...] cpan.org - Broken in 1.111 added
  Tue Jan 04 20:14:13 2011 wyant [...] cpan.org - Fixed in 1.112_001 added
  Tue Feb 15 19:19:51 2011 wyant [...] cpan.org - Fixed in 1.112_002 added
  Tue Feb 15 19:19:51 2011 wyant [...] cpan.org - Fixed in 1.113 added
  Wed Feb 23 11:27:51 2011 wyant [...] cpan.org - Status changed from 'patched' to 'resolved'