Skip Menu |

This queue is for tickets about the DBD-Pg CPAN distribution.

Report information
The Basics
Id: 63497
Status: resolved
Priority: 0/
Queue: DBD-Pg

People
Owner: Nobody in particular
Requestors: dagobert [...] cpan.org
Cc: dam [...] opencsw.org
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.17.2
Fixed in: 2.18.0



CC: dam [...] opencsw.org
Subject: Function dequote_bytea returning void should not try to return something
In the function dequote_bytea there is a shortcut trying to return a value in a void function which halts compilation with strict compilers. The attached patch fixes the issue.
Subject: 0001-Dont-return-value-in-dequote_bytea.patch
From 0242e1aa1d6f6a95a1b1addb750c35c526ee20fe Mon Sep 17 00:00:00 2001 From: Dagobert Michelsen <dam@opencsw.org> Date: Wed, 1 Dec 2010 12:27:55 +0100 Subject: [PATCH] Dont return value in dequote_bytea --- quote.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/quote.c b/quote.c index 96ca12f..f8a7249 100644 --- a/quote.c +++ b/quote.c @@ -529,9 +529,10 @@ void dequote_bytea(char *string, STRLEN *retlen, int estring) return; if ('\\' == *string && 'x' == *(string+1)) - return _dequote_bytea_hex(string, retlen, estring); + _dequote_bytea_hex(string, retlen, estring); else - return _dequote_bytea_escape(string, retlen, estring); + _dequote_bytea_escape(string, retlen, estring); + return; } /* -- 1.7.3
Thanks! Patch applied in r14559.