Bug #63321 for Net-DNS: FW: Bug in Net::DNS::Nameserver.pm Version 835

Wed Nov 24 20:03:28 2010 Mark [...] infocomm.com - Ticket created

Subject:	FW: Bug in Net::DNS::Nameserver.pm Version 835
Date:	Wed, 24 Nov 2010 17:03:17 -0800
To:	<bug-Net-DNS [...] rt.cpan.org>
From:	"Mark Pizzolato - Info Comm" <Mark [...] infocomm.com>

Reporting to rt.cpan.org as requested. From: Mark Pizzolato - Info Comm Sent: Wednesday, November 24, 2010 1:28 PM To: 'olaf@net-dns.org' Subject: Bug in Net::DNS::Nameserver.pm Version 835 Hi there Olaf, I encountered a bug in the code for Nameserver.pm The bug is obvious when a Nameserver object is created without specifying a NotifyHandler and the resulting object actually receives a NS_NOTIFY_OP packet. The existing code sees that no NotifyHandler was specified when the Nameserver object was created and sets a SERVFAIL rcode, BUT then it calls the missing notify handler anyway! The attached patch fixes the problem. - Mark Pizzolato

Message body is not shown because sender requested not to inline it.

Mon Jan 17 06:34:18 2011 willem [...] cpan.org - Correspondence added

Hi Mark, Indeed! I've applied the patch. Also, because of what I read in RFC1996: 3.12. If a NOTIFY request is received by a slave who does not implement the NOTIFY opcode, it will respond with a NOTIMP (unimplemented feature error) message. A master server who receives such a NOTIMP should consider the NOTIFY transaction complete for that slave. I believe the correct response code should be NOTIMP and not SERVFAIL. I have altered that too. I believe it is save to make this change, because nobody could have checked for SERVFAIL, as the Nameserver simply crashed before. Regards, Willem

Mon Jan 17 06:34:19 2011 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 17 06:34:19 2011 willem [...] cpan.org - Status changed from 'open' to 'resolved'