Skip Menu |

This queue is for tickets about the Term-Cap CPAN distribution.

Report information
The Basics
Id: 63268
Status: resolved
Priority: 0/
Queue: Term-Cap

People
Owner: Nobody in particular
Requestors: ntyni [...] iki.fi
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 1.12
Fixed in: (no value)



Subject: tests skipped when only infocmp -C works
If there's no termcap file available but "infocmp -C" works, the module will happily use it but the test suite gets skipped. Proposed patch attached, this works for me on an up to date Debian unstable system. I hope this is the right place to report bugs; you might want to inform perl5-porters as Porting/Maintainers.pl in the Perl core doesn't know if the canonical upstream is the CPAN version or the core one. Thanks for your work on Term-Cap, -- Niko Tyni ntyni@debian.org
Subject: 0001-Don-t-skip-the-tests-when-infocmp-works.patch
From 351ce7bb411da734e778bdc59ea4907fe55d52c9 Mon Sep 17 00:00:00 2001 From: Niko Tyni <ntyni@debian.org> Date: Tue, 23 Nov 2010 14:51:13 +0200 Subject: [PATCH 1/2] Don't skip the tests when infocmp works If there's no termcap file available but "infocmp -C" works, the module will happily use it but the test suite gets skipped. --- test.pl | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/test.pl b/test.pl index 1f046e4..28efff8 100644 --- a/test.pl +++ b/test.pl @@ -24,7 +24,8 @@ my $files = join '', ( $ENV{HOME} . '/.termcap', # we assume pretty UNIXy system anyway '/etc/termcap', '/usr/share/misc/termcap' ); -unless( $files || $^O eq 'VMS' ) { +my $terminfo = `infocmp -C 2>/dev/null`; +unless( $files || $terminfo || $^O eq 'VMS' ) { plan skip_all => 'no termcap available to test'; } else { -- 1.7.2.3
On Tue Nov 23 08:15:07 2010, ntyni@iki.fi wrote: Show quoted text
> If there's no termcap file available but "infocmp -C" works, > the module will happily use it but the test suite gets skipped. > > Proposed patch attached, this works for me on an up to date Debian > unstable system. > > I hope this is the right place to report bugs; you might want to inform > perl5-porters as Porting/Maintainers.pl in the Perl core doesn't know if > the canonical upstream is the CPAN version or the core one. > > Thanks for your work on Term-Cap,
Thanks, belatedly applied in https://github.com/jonathanstowe/Term-Cap/commit/db0cd282e46efdc67456bcb88cc34376d9936809