Skip Menu |

This queue is for tickets about the IMDB-Film CPAN distribution.

Report information
The Basics
Id: 63255
Status: open
Priority: 0/
Queue: IMDB-Film

People
Owner: Nobody in particular
Requestors: gerph [...] gerph.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.48
Fixed in: (no value)



Subject: "Kind" of movies default to 'Movie'
Previously the 'kind' of movies was returned as 'movie' by default. This appears to have been changed to 'Movie'. Not too important but it looks affects my code that explicitly checks for the lower case variant. In sub title: $elf->{_kind} = 'Movie' unless $self->{_kind}; # Default kind should be movie should probably be: $self->{_kind} = 'movie' unless $self->{_kind}; # Default kind should be movie Similar problem with: http://www.imdb.com/title/tt0118692/ which returns 'Video'. I think that particular problem is that %FILM_KIND needs updating to have a video entry: Video => 'video movie', Possibly related, searching for '10th Kingdom' or 'The Triangle' 2005 returns entries which have kind set to 'tv series', but which list on the IMDB page as 'TV mini series': http://www.imdb.com/title/tt0452573/ http://www.imdb.com/title/tt0207275/ Probably that's because of the "s in the name; the intention, from the %FILM_KIND appeared to be to return the mini-series differently - I'm not sure if that's a good or bad behaviour.
Subject: Re: [rt.cpan.org #63255] "Kind" of movies default to 'Movie'
Date: Tue, 23 Nov 2010 16:12:21 +0200
To: bug-IMDB-Film [...] rt.cpan.org
From: Michael Stepanov <stepanov.michael [...] gmail.com>
Hi Justin, I made the kind in lower case. And hash %FILM_KIND is not used anymore. Because IMDB added full kind of the movies. On Tue, Nov 23, 2010 at 6:42 AM, Justin Fletcher via RT < bug-IMDB-Film@rt.cpan.org> wrote: Show quoted text
> Mon Nov 22 23:42:56 2010: Request 63255 was acted upon. > Transaction: Ticket created by gerph > Queue: IMDB-Film > Subject: "Kind" of movies default to 'Movie' > Broken in: 0.48 > Severity: Normal > Owner: Nobody > Requestors: gerph@gerph.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=63255 > > > > Previously the 'kind' of movies was returned as 'movie' by default. > This appears to have been changed to 'Movie'. Not too important but it > looks affects my code that explicitly checks for the lower case variant. > > In sub title: > > $elf->{_kind} = 'Movie' unless $self->{_kind}; # Default kind should > be movie > should probably be: > > $self->{_kind} = 'movie' unless $self->{_kind}; # Default kind should > be movie > > > Similar problem with: > > http://www.imdb.com/title/tt0118692/ > > which returns 'Video'. > I think that particular problem is that %FILM_KIND needs updating to > have a video entry: > > Video => 'video movie', > > > Possibly related, searching for '10th Kingdom' or 'The Triangle' 2005 > returns entries which have kind set to 'tv series', but which list on > the IMDB page as 'TV mini series': > > http://www.imdb.com/title/tt0452573/ > http://www.imdb.com/title/tt0207275/ > > Probably that's because of the "s in the name; the intention, from the > %FILM_KIND appeared to be to return the mini-series differently - I'm > not sure if that's a good or bad behaviour. > >
-- Best regards, Michael Stepanov http://linuxmce.ru