Bug #63216 for IMDB-Film: Years don't work when multiple films released in a year

Sun Nov 21 18:12:30 2010 gerph [...] gerph.org - Ticket created

Subject:

Years don't work when multiple films released in a year

Looks like a simple change in the redesign of the site. If I do a lookup of 'The Enforcer' with year=1976 I get back an object that can't return a year; $imdb->year() doesn't return 1976 back. Turning debug on yields this: ---- [DEBUG] TITLE: The Enforcer (1976/I) .media_strip_thumbs img { margin- right:0.2em; border:none; } .media_strip_thumbs { overflow: hidden; height: 90px; } .media_strip_thumb img { margin-right: 0.2em; } .media_strip_thumb { float: left; margin-bottom: 50px; text- align: right; font-family: Tahoma,Verdana,sans-serif; font-size: 10pt; color:#333333; } Photos ( (/title/tt0074483/) at ./filmdetails.pl line 186 ---- which I think is why the year isn't getting found. Either that or the naming on the http://www.imdb.com/title/tt0074483/ page isn't helping: ---- <h1 class="header"> The Enforcer <span>(I)</span> <span>(<a href="/year/1976/">1976</a>)</span> </h1> ---- (sorry, I've not had time to look through the code to check the problem)

Mon Nov 22 23:49:30 2010 gerph [...] gerph.org - Correspondence added

From:

gerph [...] gerph.org

Further investigation shows that the regex in sub title needs to be updated to cope with these roman-numeral suffixes, eg: ($self->{_title}, $self->{_year}, $self->{_kind}) = $title =~ m!(.*?)\s+ $(\d{4})(?:/[IV]+)?$(?:\s$(\w*)$)?!; adding the "(?:/[IV]+)?" before the closing bracket. That should cope with up to 8 variants of a film before it fails again. Add an 'X' and we could cope with up to 39 variants of a film before it'll fail - for the addition of a letter that's to incredibly special case :-) In my test code, looking for 'The Enforcer' returns a year properly with that change.

Tue Nov 23 09:11:19 2010 stepanov.michael [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #63216] Years don't work when multiple films released in a year
Date:	Tue, 23 Nov 2010 16:10:43 +0200
To:	bug-IMDB-Film [...] rt.cpan.org
From:	Michael Stepanov <stepanov.michael [...] gmail.com>

Hi Justin, Thanks for the bugreport and suggestion. I'll add it into the next release which is planning at the end of this week. On Tue, Nov 23, 2010 at 6:49 AM, Justin Fletcher via RT < bug-IMDB-Film@rt.cpan.org> wrote: Show quoted text

> Queue: IMDB-Film > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=63216 > > > Further investigation shows that the regex in sub title needs to be > updated to cope with these roman-numeral suffixes, eg: > > ($self->{_title}, $self->{_year}, $self->{_kind}) = $title =~ m!(.*?)\s+ > $(\d{4})(?:/[IV]+)?$(?:\s$(\w*)$)?!; > > adding the "(?:/[IV]+)?" before the closing bracket. That should cope > with up to 8 variants of a film before it fails again. Add an 'X' and we > could cope with up to 39 variants of a film before it'll fail - for the > addition of a letter that's to incredibly special case :-) > > In my test code, looking for 'The Enforcer' returns a year properly with > that change. > >

-- Best regards, Michael Stepanov http://linuxmce.ru

Tue Nov 23 09:11:20 2010 The RT System itself - Status changed from 'new' to 'open'

Fri Nov 26 05:02:08 2010 stepanov.michael [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #63216] Years don't work when multiple films released in a year
Date:	Fri, 26 Nov 2010 12:01:39 +0200
To:	bug-IMDB-Film [...] rt.cpan.org
From:	Michael Stepanov <stepanov.michael [...] gmail.com>

Hi Justing, New version of IMDB::Film is uploaded to CPAN. It needs some time to make it visible via web and cpan utility. On Tue, Nov 23, 2010 at 4:11 PM, Michael Stepanov via RT < bug-IMDB-Film@rt.cpan.org> wrote: Show quoted text

> Queue: IMDB-Film > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=63216 > > > Hi Justin, > > Thanks for the bugreport and suggestion. I'll add it into the next release > which is planning at the end of this week. > > On Tue, Nov 23, 2010 at 6:49 AM, Justin Fletcher via RT < > bug-IMDB-Film@rt.cpan.org> wrote: >

> > Queue: IMDB-Film > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=63216 > > > > > Further investigation shows that the regex in sub title needs to be > > updated to cope with these roman-numeral suffixes, eg: > > > > ($self->{_title}, $self->{_year}, $self->{_kind}) = $title =~ m!(.*?)\s+ > > $(\d{4})(?:/[IV]+)?$(?:\s$(\w*)$)?!; > > > > adding the "(?:/[IV]+)?" before the closing bracket. That should cope > > with up to 8 variants of a film before it fails again. Add an 'X' and we > > could cope with up to 39 variants of a film before it'll fail - for the > > addition of a letter that's to incredibly special case :-) > > > > In my test code, looking for 'The Enforcer' returns a year properly with > > that change. > > > >

> > > -- > Best regards, > Michael Stepanov > http://linuxmce.ru > >

-- Best regards, Michael Stepanov http://linuxmce.ru