Skip Menu |

This queue is for tickets about the DBI CPAN distribution.

Report information
The Basics
Id: 6321
Status: resolved
Priority: 0/
Queue: DBI

People
Owner: Nobody in particular
Requestors: drew [...] drewtaylor.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.42
Fixed in: (no value)



Subject: Errors in _load_class not propagated
I was tracking down a problem with an web application that uses Class::DBI tonight, where all dependencies are installed as part of the application and having major problems. It turns out that I had missed a single module, but the error message never got propagated up to the browser in _load_class(). The comment says it does, but it doesn't work for me. ;-) A patch is attached which explicitely passes the error message to die(). This happened with both 5.8.4 and .3. --- DBI.pm.orig Thu Mar 11 08:45:38 2004 +++ DBI.pm Mon May 17 03:07:28 2004 @@ -879,7 +879,7 @@ eval { require "$module.pm"; }; return 1 unless $@; return 0 if $missing_ok && $@ =~ /^Can't locate \Q$module.pm\E/; - die; # propagate $@; + die $@; # propagate $@; }
Thanks. Can you provide a test small case? [guest - Mon May 17 04:22:43 2004]: Show quoted text
> I was tracking down a problem with an web application that uses > Class::DBI tonight, where all dependencies are installed as part of > the application and having major problems. It turns out that I had > missed a single module, but the error message never got propagated > up to the browser in _load_class(). The comment says it does, but > it doesn't work for me. ;-) > A patch is attached which explicitely passes the error message to > die(). This happened with both 5.8.4 and .3. > > --- DBI.pm.orig Thu Mar 11 08:45:38 2004 > +++ DBI.pm Mon May 17 03:07:28 2004 > @@ -879,7 +879,7 @@ > eval { require "$module.pm"; }; > return 1 unless $@; > return 0 if $missing_ok && $@ =~ /^Can't locate \Q$module.pm\E/; > - die; # propagate $@; > + die $@; # propagate $@; > }
Thanks.