Bug #63101 for Perl-Critic: Build problem with Perl::Critic 1.109 and 1.108

Wed Nov 17 20:10:34 2010 pettit [...] yahoo-inc.com - Ticket created

Subject:	Build problem with Perl::Critic 1.109 and 1.108
Date:	Wed, 17 Nov 2010 17:10:12 -0800
To:	bug-Perl-Critic [...] rt.cpan.org
From:	"Mark K. Pettit" <pettit [...] yahoo-inc.com>

I'm attempting to build and install Perl-Critic-1.109. I have Mac OS X with Perl 5.10.0 installed. I'm able to successfull untar the package, run "perl Makefile.PL" and "make". But "make test" fails with this error: [coconutpa-lm:~/unb/Perl-Critic-1.109]$ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00_modules.t ................................ Couldn't require Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict : version version 0.77 required--this is only version 0.74 at /Users/pettit/unb/Perl-Critic-1.109/blib/lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm line 13. BEGIN failed--compilation aborted at /Users/pettit/unb/Perl-Critic-1.109/blib/lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm line 13. Compilation failed in require at (eval 147) line 3. at /System/Library/Perl/5.10.0/Module/Pluggable.pm line 28 t/00_modules.t ................................ 1180/2606 # Failed test 'use Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict;' Bailout called. Further testing stopped: Can't continue. # at t/00_modules.t line 292. # Tried to use 'Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict'. # Error: Attempt to reload Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm aborted. # Compilation failed in require at (eval 439) line 2. # BEGIN failed--compilation aborted at (eval 439) line 2. FAILED--Further testing stopped: Can't continue. make: *** [test_dynamic] Error 255 [coconutpa-lm:~/unb/Perl-Critic-1.109]$ It seems you have some code that requires "Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict" version 0.77, but you only include version 0.74 in the package. If I can provide further assistance, let me know. Mark Pettit pettit@yahoo-inc.com DNS Architect, Yahoo!, Inc.

Wed Nov 17 22:47:20 2010 wyant [...] cpan.org - Correspondence added

On Wed Nov 17 20:10:34 2010, pettit@yahoo-inc.com wrote: Show quoted text

> I'm attempting to build and install Perl-Critic-1.109. I have Mac OS > X with Perl 5.10.0 installed. > > I'm able to successfull untar the package, run "perl Makefile.PL" and > "make". > > But "make test" fails with this error: > > [coconutpa-lm:~/unb/Perl-Critic-1.109]$ make test > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/00_modules.t ................................ Couldn't require > Perl::Critic::Policy::TestingAndDebugging::RequireUseStrict : > version version 0.77 required--this is only version 0.74 at > /Users/pettit/unb/Perl-Critic- >

1.109/blib/lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm Show quoted text

> line 13. > BEGIN failed--compilation aborted at /Users/pettit/unb/Perl-Critic- >

1.109/blib/lib/Perl/Critic/Policy/TestingAndDebugging/RequireUseStrict.pm Show quoted text

> line 13.

<snip /> This looks to me like a repeat of RT #60510, though it took a few minutes to realize it. The problem is not the version of the Perl::Critic RequireUseStrict policy, but the version of the 'version' pragma. The failing line (in the RequireUseStrict policy) is use version 0.77; and the errors appear to be trying to tell us that you only have version 0.74 installed. You can check this with perl -Mversion -E 'say version->VERSION' Try upgrading the version pragma to 0.77 or greater and see how it goes. The easiest is to upgrade to the current version which is something like 0.84. Normally, if you use an installer like cpan or cpanp (both of which come with perl 10.0.0) all this sort of thing will be taken care of for you. I highly recommend recommend using one of them over downloading tarballs and sorting out the dependencies on your own. But in the case of the 'version' version, Perl::Critic failed to declare in its metadata that it needs 'version' version 0.77. This should be fixed in the next release (famous last words!), but until then you will still need to upgrade 'version' yourself. I'm going to allow a few days for give and take before I conclude that this is truly the problem and mark it 'patched'. Tom Wyant

Wed Nov 17 22:47:21 2010 The RT System itself - Status changed from 'new' to 'open'

Sun Nov 28 18:01:59 2010 wyant [...] cpan.org - Correspondence added

In the absence of further feedback, I'm going to assume that upgrading 'version' solved the problem, and call this patched. Please let me know if I'm wrong. Tom

Sun Nov 28 18:02:00 2010 wyant [...] cpan.org - Status changed from 'open' to 'patched'

Mon Nov 29 19:10:21 2010 pettit [...] yahoo-inc.com - Correspondence added

Subject:	Re: [rt.cpan.org #63101] Build problem with Perl::Critic 1.109 and 1.108
Date:	Mon, 29 Nov 2010 16:09:58 -0800
To:	"bug-Perl-Critic [...] rt.cpan.org" <bug-Perl-Critic [...] rt.cpan.org>
From:	"Mark K. Pettit" <pettit [...] yahoo-inc.com>

I'm sorry, I somehow missed your reply on the 17th. Yes, upgrading to "version" 0.86 fixed this. Regarding your "use cpan" advice, I actually did use CPAN originally but wanted to show you the error output using an actual command-line build (it seemed easier). :) Yeah, "use version 0.77;" confused me for some reason. I don't know why I didn't realize it was asking for the "version" module. Thanks for the quick response and help to get Perl::Critic installed. On Nov 28, 2010, at 3:02 PM, Tom Wyant via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=63101 > > > In the absence of further feedback, I'm going to assume that upgrading > 'version' solved the problem, and call this patched. Please let me know > if I'm wrong. > > Tom

Mon Nov 29 19:10:22 2010 The RT System itself - Status changed from 'patched' to 'open'

Mon Nov 29 19:39:20 2010 wyant [...] cpan.org - Correspondence added

On Mon Nov 29 19:10:21 2010, pettit@yahoo-inc.com wrote: Show quoted text

> I'm sorry, I somehow missed your reply on the 17th.

No sweat. Show quoted text

> > Yes, upgrading to "version" 0.86 fixed this. Regarding your "use > cpan" advice, I actually did use CPAN originally but wanted to show > you the error output using an actual command-line build (it seemed > easier). :) >

Thanks for the extra effort. Show quoted text

> Yeah, "use version 0.77;" confused me for some reason. I don't know > why I didn't realize it was asking for the "version" module. >

Probably because "version version 0.77 required" is far from clear.

Mon Nov 29 19:39:21 2010 wyant [...] cpan.org - Status changed from 'open' to 'patched'

Tue Dec 07 10:42:25 2010 wyant [...] cpan.org - Fixed in 1.110_001 added

Tue Jan 04 20:15:09 2011 wyant [...] cpan.org - Broken in 1.108 added

Tue Jan 04 20:15:09 2011 wyant [...] cpan.org - Broken in 1.109 added

Tue Jan 04 20:15:10 2011 wyant [...] cpan.org - Broken in 1.111 added

Tue Jan 04 20:15:10 2011 wyant [...] cpan.org - Fixed in 1.112_001 added

Tue Feb 15 19:20:38 2011 wyant [...] cpan.org - Fixed in 1.112_002 added

Tue Feb 15 19:20:38 2011 wyant [...] cpan.org - Fixed in 1.113 added

Wed Feb 23 11:27:25 2011 wyant [...] cpan.org - Status changed from 'patched' to 'resolved'

Bug #63101 for Perl-Critic: Build problem with Perl::Critic 1.109 and 1.108

Preferred bug tracker