Bug #63090 for Devel-Cover: conditionals where one element is data from a Moose attrib are not evaluated

Wed Nov 17 10:50:51 2010 MITHALDU [...] cpan.org - Ticket created

Subject:

conditionals where one element is data from a Moose attrib are not evaluated

I have a small script, which seems to demonstrate a bug in Devel::Cover: https://gist.github.com/703513 What happens is that the code runs through and the || condition is properly evaluated and both paths exercised as demonstrated by the output. However the condition evaluation of Devel::Cover claims the || was neither true nor false at any point. This seems to be caused by "meep" being a moose attribute sub AND the attempt to use data from the hash it returns. The || is evaluated properly if the "->{marp}" part is left off, or when meep is replaced with a fully declared sub-routine.

Wed Nov 17 11:39:33 2010 MITHALDU [...] cpan.org - Correspondence added

Forgot to note this: As far as i can tell this is independent of perl version or platform. I asked around on IRC and it was reproduced across multiple perl versions and platforms, from windows, to linux, to solaris.

Tue May 22 20:21:48 2012 PJCJ [...] cpan.org - Correspondence added

Thanks very much for this report. It is fixed by 4283f27 and your test case has been added as a test.

Tue May 22 20:21:49 2012 The RT System itself - Status changed from 'new' to 'open'

Tue May 22 20:21:49 2012 PJCJ [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jun 05 07:21:20 2012 MITHALDU [...] cpan.org - Correspondence added

I just got some coverage on code and it seems this is not yet fixed for me. You can see output on the example script i gave you in this gist: https://gist.github.com/703513#file_output+with+dc+0.87

Tue Jun 05 07:21:21 2012 The RT System itself - Status changed from 'resolved' to 'open'

Tue Jun 05 10:07:11 2012 MITHALDU [...] cpan.org - Correspondence added

And a test output from Tux demonstrating that this behavior is consistent across OSes and perl versions: http://pasta.test-smoke.org/264

Tue Jun 05 11:45:00 2012 MITHALDU [...] cpan.org - Correspondence added

Turns out that this behavior is ok, since the fix wasn't actually released yet. However a very similar issue has been found in Moo: https://github.com/pjcj/Devel--Cover/pull/20/files

Tue Jun 05 11:45:17 2012 MITHALDU [...] cpan.org - Broken in 0.87 added

Mon Sep 03 11:21:03 2012 MITHALDU [...] cpan.org - Correspondence added

To ping this, the pull request still demonstrates the issue tersely and the issue still exists.

Mon Sep 03 11:21:16 2012 MITHALDU [...] cpan.org - Broken in 0.93 added

Wed Sep 19 21:11:53 2012 PJCJ [...] cpan.org - Correspondence added

Thanks for the updated report. This has been fixed by eedecbd which will be in the next release. Thanks again,

Wed Sep 19 21:11:54 2012 PJCJ [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #63090 for Devel-Cover: conditionals where one element is data from a Moose attrib are not evaluated

Preferred bug tracker