Skip Menu |

This queue is for tickets about the HTTP-Parser-XS CPAN distribution.

Report information
The Basics
Id: 63074
Status: resolved
Priority: 0/
Queue: HTTP-Parser-XS
People
Owner: Nobody in particular
Requestors: james2vegas [...] aim.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 0.08
  • 0.09
  • 0.10
  • 0.11
  • 0.12
Fixed in: (no value)

History Show all quoted text
  Wed Nov 17 00:30:18 2010 james2vegas [...] aim.com - Ticket created
Subject: 0.08 breaks on older (2.x) gcc compilers
/usr/libexec/ld-elf.so.1: /usr/local/lib/perl5/site_perl/5.8.9/i386-freebsd/auto/HTTP/Parser/XS/XS.so: Undefined symbol "__builtin_expect"
Changing the check in picohttpparser/picohttpparser.c to be explicit about GCC version fixes it:

--- picohttpparser/picohttpparser.c.orig        Tue Nov 16 21:28:14 2010
+++ picohttpparser/picohttpparser.c     Tue Nov 16 21:28:41 2010
@@ -1,7 +1,7 @@
 #include <stddef.h>
 #include "picohttpparser.h"
 
-#ifdef __GNUC__
+#if __GNUC__ >= 3
 # define likely(x)     __builtin_expect(!!(x), 1)
 # define unlikely(x)   __builtin_expect(!!(x), 0)
 #else

  Tue Dec 07 21:20:01 2010 KAZUHO [...] cpan.org - Correspondence added
Thank you for reporting. Fixed in 0.13.
  Tue Dec 07 21:20:02 2010 The RT System itself - Status changed from 'new' to 'open'
  Tue Dec 07 21:20:02 2010 KAZUHO [...] cpan.org - Status changed from 'open' to 'resolved'
  Tue Dec 07 21:20:05 2010 KAZUHO [...] cpan.org - Correspondence added
Thank you for reporting. Fixed in 0.13.
  Tue Dec 07 21:20:06 2010 The RT System itself - Status changed from 'resolved' to 'open'
  Tue Dec 07 21:20:07 2010 KAZUHO [...] cpan.org - Status changed from 'open' to 'resolved'