Skip Menu |

This queue is for tickets about the SQL-Translator CPAN distribution.

Report information
The Basics
Id: 63022
Status: resolved
Priority: 0/
Queue: SQL-Translator

People
Owner: Nobody in particular
Requestors: bokutin [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.11006
Fixed in: 0.11011



Subject: int(10) vs int(11)
http://www.issociate.de/board/post/504719/int%2810%29_va_int%2811%29.html % diff lib/SQL/Translator/Parser/MySQL.pm lib/SQL/Translator/Parser/MySQL.pm.orig 973,975c973,974 < my $default = $field->{extra}{unsigned} ? 3 : 4; < $changed = $size != $default; < $size = $default; --- Show quoted text
> $changed = $size != 4; > $size = 4;
978,979c977 < my $default = $field->{extra}{unsigned} ? 5 : 6; < $changed = $size != $default; --- Show quoted text
> $changed = $size != 6;
983,985c981,982 < my $default = $field->{extra}{unsigned} ? 8 : 9; < $changed = $size != $default; < $size = $default; --- Show quoted text
> $changed = $size != 9; > $size = 9;
988,989c985 < my $default = $field->{extra}{unsigned} ? 10 : 11; < $changed = $size != $default || $type ne 'int'; --- Show quoted text
> $changed = $size != 11 || $type ne 'int';
991c987 < $size = $default; --- Show quoted text
> $size = 11;
994,996c990,991 < my $default = $field->{extra}{unsigned} ? 19 : 20; < $changed = $size != $default; < $size = $default; --- Show quoted text
> $changed = $size != 20; > $size = 20;
This patch seems to have been submitted against an old version of Parser/MySQL.pm. Can you please submit a patch against the current version, while also verifying that the tests still pass? Thanks!
It looks like a variation of this was committed here http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=dbsrgits/SQL-Translator.git;a=commitdiff;h=936e626bc9111bfbe8319a8558fe4c04a58c1008 Feel free to reopen this ticket if something was overlooked. Cheers!