Skip Menu |

This queue is for tickets about the GDGraph CPAN distribution.

Maintainer(s)' notes

There are plenty of good ideas of what people can do published here on the queue. Turning a patch from the tracker into a pull request is not one of them. In order to get maintainers' attention way more quickier, PR should have at least a sample included. We know it's hard to test images generating software, but it doesn't mean we can not test numbers produced by intermediate algorithms used to generate these images, so either a test or a sample.

Report information
The Basics
Id: 62920
Status: open
Priority: 0/
Queue: GDGraph
People
Owner: Nobody in particular
Requestors: patermanns [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: 1.44
Fixed in: (no value)
Attachments
05_x_axis_ticks.diff
test_chart05a.png
test_chart05b.png
test_chartg05a.pl
test_chartg05b.pl

History Show all quoted text
  Thu Nov 11 05:52:25 2010 patermanns [...] gmail.com - Ticket created
Subject: Maximise x-axis usage when using text labels [PATCH]
When the x-axis tick labels are text rather than numeric, the first tick/label currently appears at x = 1, rather than x = 0. Similarly, the last tick/label appears at max(x)-1 rather than max(x). This is particularly noticeable on line graphs, especially when using two_axes. To give the option to maximise usage of the x-axis when using text labels, I have allowed x_tick_number to take the values 0 and -1, both values indicating that the labels are text rather than numeric. A value of zero is now the default and is equivalent to leaving x_tick_number undefined in the previous version, so the graph produced should be the same as before. If x_tick_number is set to -1, however, the ticks are adjusted so that the first appears at x = 0 and the last at x = max(x). Note that this has been disabled for area graphs and bar charts by forcing x_tick_number to 0 if it is negative. A patch to area.pm, axestype.pm, bars.pm, lines.pm and points.pm is attached. Note that, although it is independent of my previous patches to axestype.pm, the patch assumes that those patches have been applied. If not, the line numbers may have to be adjusted. Tested with ActiveState Perl 5.8.9 on Windows XP and Perl 5.8.8 on Red Hat Enterprise Linux 5.3 (64-bit).
Subject: 05_x_axis_ticks.diff
*** old\area.pm Wed Apr 25 20:16:10 2007 --- new\area.pm Wed Nov 10 15:51:02 2010 *************** *** 19,24 **** --- 19,31 ---- @GD::Graph::area::ISA = qw( GD::Graph::axestype ); + sub initialise + { + my $self = shift; + $self->SUPER::initialise(); + $self->{x_tick_number} = 0 if $self->{x_tick_number} < 0; + } + # PRIVATE sub draw_data_set { *** old\axestype.pm Wed Nov 10 16:09:07 2010 --- new\axestype.pm Wed Nov 10 16:42:04 2010 *************** *** 35,41 **** # Number of ticks for the y axis y_tick_number => 5, ! x_tick_number => undef, # CONTRIB Scott Prahl x_tick_offset => 0, # CONTRIB Damon Brodi # Skip every nth label. if 1 will print every label on the axes, --- 35,41 ---- # Number of ticks for the y axis y_tick_number => 5, ! x_tick_number => 0, # CONTRIB Scott Prahl x_tick_offset => 0, # CONTRIB Damon Brodi # Skip every nth label. if 1 will print every label on the axes, *************** *** 561,567 **** $self->setup_left_boundary(); $self->setup_right_boundary(); ! if ($self->correct_width && !$self->{x_tick_number}) { if (! $self->{rotate_chart}) { --- 561,567 ---- $self->setup_left_boundary(); $self->setup_right_boundary(); ! if ($self->correct_width && $self->{x_tick_number} <= 0) { if (! $self->{rotate_chart}) { *************** *** 603,609 **** # calculate the step size for x data # CONTRIB Changes by Scott Prahl ! if (defined $s->{x_tick_number}) { my $delta = ($s->{right} - $s->{left})/($s->{x_max} - $s->{x_min}); # 'True' numerical X axis addition # From: Gary Deschaines --- 603,609 ---- # calculate the step size for x data # CONTRIB Changes by Scott Prahl ! if ($s->{x_tick_number} > 0) { my $delta = ($s->{right} - $s->{left})/($s->{x_max} - $s->{x_min}); # 'True' numerical X axis addition # From: Gary Deschaines *************** *** 623,629 **** } else { ! $s->{x_step} = ($s->{right} - $s->{left})/($s->{_data}->num_points + 1); $s->{x_offset} = $s->{left}; } } --- 623,631 ---- } else { ! my $num_points = !$s->{x_tick_number}? $s->{_data}->num_points + 1: ! $s->{_data}->num_points - 1; ! $s->{x_step} = ($s->{right} - $s->{left})/$num_points; $s->{x_offset} = $s->{left}; } } *************** *** 634,640 **** # calculate the step size for x data # CONTRIB Changes by Scott Prahl ! if (defined $s->{x_tick_number}) { my $delta = ($s->{bottom} - $s->{top})/($s->{x_max} - $s->{x_min}); # 'True' numerical X axis addition # From: Gary Deschaines --- 636,642 ---- # calculate the step size for x data # CONTRIB Changes by Scott Prahl ! if ($s->{x_tick_number} > 0) { my $delta = ($s->{bottom} - $s->{top})/($s->{x_max} - $s->{x_min}); # 'True' numerical X axis addition # From: Gary Deschaines *************** *** 654,660 **** } else { ! $s->{x_step} = ($s->{bottom} - $s->{top})/($s->{_data}->num_points + 1); $s->{x_offset} = $s->{top}; } } --- 656,664 ---- } else { ! my $num_points = !$s->{x_tick_number}? $s->{_data}->num_points + 1: ! $s->{_data}->num_points - 1; ! $s->{x_step} = ($s->{bottom} - $s->{top})/$num_points; $s->{x_offset} = $s->{top}; } } *************** *** 695,705 **** # CONTRIB Scott Prahl # make sure that we can generate valid x tick marks ! undef($s->{x_tick_number}) if $s->{_data}->num_points < 3; ! undef($s->{x_tick_number}) if !defined $s->{x_max} || !defined $s->{x_min} || $s->{x_max} == $s->{x_min}; $s->{rotate_chart} ? $s->setup_x_step_size_h() : $s->setup_x_step_size_v(); --- 699,711 ---- # CONTRIB Scott Prahl # make sure that we can generate valid x tick marks ! if ($s->{x_tick_number} > 0) { ! $s->{x_tick_number} = 0 if $s->{_data}->num_points < 3; ! $s->{x_tick_number} = 0 if !defined $s->{x_max} || !defined $s->{x_min} || $s->{x_max} == $s->{x_min}; + } $s->{rotate_chart} ? $s->setup_x_step_size_h() : $s->setup_x_step_size_v(); *************** *** 763,769 **** { my $self = shift; ! my @values = $self->{x_tick_number} ? @{$self->{x_values}} : $self->{_data}->x_values; --- 769,775 ---- { my $self = shift; ! my @values = ($self->{x_tick_number} > 0)? @{$self->{x_values}} : $self->{_data}->x_values; *************** *** 787,793 **** $self->{x_label_height} = 0; $self->{x_label_width} = 0; ! if (defined $self->{x_tick_number}) { # We want to emulate numerical x axes foreach my $t (0..$self->{x_tick_number}) --- 793,799 ---- $self->{x_label_height} = 0; $self->{x_label_width} = 0; ! if ($self->{x_tick_number} > 0) { # We want to emulate numerical x axes foreach my $t (0..$self->{x_tick_number}) *************** *** 1123,1129 **** for (my $i = 0; $i < $self->{_data}->num_points; $i++) { ! my ($x, $y) = $self->val_to_pixel($i + 1, 0, 1); $x = $self->{left} unless $self->{zero_axis_only}; --- 1129,1136 ---- for (my $i = 0; $i < $self->{_data}->num_points; $i++) { ! my $p = ($self->{x_tick_number} < 0)? $i: $i + 1; ! my ($x, $y) = $self->val_to_pixel($p, 0, 1); $x = $self->{left} unless $self->{zero_axis_only}; *************** *** 1192,1198 **** for (my $i = 0; $i < $self->{_data}->num_points; $i++) { ! my ($x, $y) = $self->val_to_pixel($i + 1, 0, 1); $y = $self->{bottom} unless $self->{zero_axis_only}; --- 1199,1206 ---- for (my $i = 0; $i < $self->{_data}->num_points; $i++) { ! my $p = ($self->{x_tick_number} < 0)? $i: $i + 1; ! my ($x, $y) = $self->val_to_pixel($p, 0, 1); $y = $self->{bottom} unless $self->{zero_axis_only}; *************** *** 1364,1370 **** return $self unless $self->{x_plot_values}; ! if (defined $self->{x_tick_number}) { $self->draw_x_ticks_number() or return; } --- 1372,1378 ---- return $self unless $self->{x_plot_values}; ! if ($self->{x_tick_number} > 0) { $self->draw_x_ticks_number() or return; } *************** *** 1579,1585 **** _best_ends($y_min, $y_max, @$self{'y_tick_number','y_min_range'}); } ! if (defined($self->{x_tick_number})) { if (defined($self->{x_min_value}) && defined($self->{x_max_value})) { --- 1587,1593 ---- _best_ends($y_min, $y_max, @$self{'y_tick_number','y_min_range'}); } ! if ($self->{x_tick_number} > 0) { if (defined($self->{x_min_value}) && defined($self->{x_max_value})) { *************** *** 1930,1936 **** } else { ! $ret_x = ($self->{x_tick_number} ? $self->{x_offset} : $origin) + $x * $self->{x_step}; } my $ret_y = $self->{rotate_chart} ? --- 1938,1944 ---- } else { ! $ret_x = (($self->{x_tick_number} > 0)? $self->{x_offset} : $origin) + $x * $self->{x_step}; } my $ret_y = $self->{rotate_chart} ? *** old\bars.pm Wed Apr 25 20:16:10 2007 --- new\bars.pm Wed Nov 10 15:50:05 2010 *************** *** 28,33 **** --- 28,34 ---- my $self = shift; $self->SUPER::initialise(); $self->set(correct_width => 1); + $self->{x_tick_number} = 0 if $self->{x_tick_number} < 0; } sub draw_data *** old\lines.pm Tue Dec 13 19:13:00 2005 --- new\lines.pm Wed Nov 10 15:39:09 2010 *************** *** 34,40 **** my $dsci = $self->set_clr($self->pick_data_clr($ds) ); my $type = $self->pick_line_type($ds); ! my ($xb, $yb); if (defined $values[0]) { if (defined($self->{x_min_value}) && defined($self->{x_max_value})) --- 34,40 ---- my $dsci = $self->set_clr($self->pick_data_clr($ds) ); my $type = $self->pick_line_type($ds); ! my ($xb, $yb, $p); if (defined $values[0]) { if (defined($self->{x_min_value}) && defined($self->{x_max_value})) *************** *** 44,50 **** } else { ! ($xb, $yb) = $self->val_to_pixel(1, $values[0], $ds); } } --- 44,51 ---- } else { ! $p = ($self->{x_tick_number} < 0)? 0: 1; ! ($xb, $yb) = $self->val_to_pixel($p, $values[0], $ds); } } *************** *** 65,71 **** } else { ! ($xe, $ye) = $self->val_to_pixel($i+1, $values[$i], $ds); } if (defined $xb) --- 66,73 ---- } else { ! $p = ($self->{x_tick_number} < 0)? $i: $i + 1; ! ($xe, $ye) = $self->val_to_pixel($p, $values[$i], $ds); } if (defined $xb) *** old\points.pm Tue Dec 13 19:13:32 2005 --- new\points.pm Wed Nov 10 15:55:20 2010 *************** *** 45,51 **** } else { ! ($xp, $yp) = $self->val_to_pixel($i+1, $values[$i], $ds); } $self->marker($xp, $yp, $type, $dsci ); $self->{_hotspots}->[$ds]->[$i] = --- 45,52 ---- } else { ! my $p = ($self->{x_tick_number} < 0)? $i: $i + 1; ! ($xp, $yp) = $self->val_to_pixel($p, $values[$i], $ds); } $self->marker($xp, $yp, $type, $dsci ); $self->{_hotspots}->[$ds]->[$i] =
  Thu Nov 11 06:56:41 2010 patermanns [...] gmail.com - Correspondence added
From: patermanns [...] gmail.com
I attach a short test program that shows the issue (test_chartg05a.pl) and one that shows the effect of the new setting (test_chartg05b.pl). I also attach the resulting output from both.
Subject: test_chart05a.png
Download test_chart05a.png
image/png 2k
test_chart05a.png
Subject: test_chart05b.png
Download test_chart05b.png
image/png 2.1k
test_chart05b.png
Subject: test_chartg05a.pl
#!/usr/bin/perl -w use strict; use GD::Graph::lines; my $data1 = '50,30,40,150,60,70,80,120,180,90,20,210'; my $data2 = '400,545,450,600,750,400,1200,800,1000,500,900,1100'; my @x_axis_data = qw(00:00 01:00 02:00 03:00 04:00 05:00 06:00 07:00 08:00 09:00 10:00 11:00 12:00 13:00 14:00 15:00 16:00 17:00 18:00 19:00 20:00 21:00 22:00 23:00 23:59 ); my @y1_axis_data = split(/,/, $data1); my @y2_axis_data = split(/,/, $data2); my @data = ( \@x_axis_data, \@y1_axis_data, \@y2_axis_data ); my $graph = GD::Graph::lines->new(240, 175); $graph->set( title => 'Test 2 Axes', transparent => 0, dclrs => [ qw(red blue) ], # bgclr => 'white', line_width => 2, two_axes => 2, x_label_skip => 4, y1_min_value => 0, y1_max_value => 250, y2_min_value => 400, y2_max_value => 1200, tick_length => -4 ) or die $graph->error; $graph->set_legend(split(/,/, 'Line1,Line2')); my $gd = $graph->plot(\@data) or die $graph->error; open(IMAGE,">test_chart05a.png") or die "Cannot open output file\n"; binmode(IMAGE); print IMAGE $gd->png; close(IMAGE);
Subject: test_chartg05b.pl
#!/usr/bin/perl -w use strict; use GD::Graph::lines; my $data1 = '50,30,40,150,60,70,80,120,180,90,20,210'; my $data2 = '400,545,450,600,750,400,1200,800,1000,500,900,1100'; my @x_axis_data = qw(00:00 01:00 02:00 03:00 04:00 05:00 06:00 07:00 08:00 09:00 10:00 11:00 12:00 13:00 14:00 15:00 16:00 17:00 18:00 19:00 20:00 21:00 22:00 23:00 23:59 ); my @y1_axis_data = split(/,/, $data1); my @y2_axis_data = split(/,/, $data2); my @data = ( \@x_axis_data, \@y1_axis_data, \@y2_axis_data ); my $graph = GD::Graph::lines->new(240, 175); $graph->set( title => 'Test 2 Axes', transparent => 0, dclrs => [ qw(red blue) ], # bgclr => 'white', line_width => 2, two_axes => 2, x_label_skip => 4, x_tick_number => -1, y1_min_value => 0, y1_max_value => 250, y2_min_value => 400, y2_max_value => 1200, tick_length => -4 ) or die $graph->error; $graph->set_legend(split(/,/, 'Line1,Line2')); my $gd = $graph->plot(\@data) or die $graph->error; open(IMAGE,">test_chart05b.png") or die "Cannot open output file\n"; binmode(IMAGE); print IMAGE $gd->png; close(IMAGE);
  Fri Jun 21 16:51:54 2013 RUZ [...] cpan.org - Correspondence added
Subject: New GD::Graph co-maintainer and new release on CPAN
Hello, You recieved this message as you filed a bug report or feature request against GD::Graph module on CPAN. My name is Ruslan and I'm new co-maintainer of the module. I've updated the module to 1.45 with doc changes and released it to CPAN. See distribution status [1]. I have TODO list for several releases, so if your ticket was a patch then turning it into a nice pull request may expedite inclusion :) [1] http://search.cpan.org/~ruz/GDGraph-1.45/Graph.pm#DISTRIBUTION_STATUS -- Best regards, Ruslan.
  Fri Jun 21 16:51:54 2013 The RT System itself - Status changed from 'new' to 'open'