Bug #62667 for SOAP-Lite: User reported crash; patch supplied

Wed Nov 03 08:01:29 2010 SILASMONK [...] cpan.org - Ticket created

Subject:

User reported crash; patch supplied

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602056 "Using the (slightly modified) examples at: http://guide.soaplite.com/ causes the client to die with: Not a HASH reference at /usr/share/perl5/SOAP/Lite.pm line 3755."

Subject:

hashref_crash.patch

Author: Ashish Shukla <wahjava@members.fsf.org> Subject: use 'ref' rather than 'UNIVERSAL::isa' --- a/lib/SOAP/Lite.pm +++ b/lib/SOAP/Lite.pm @@ -3747,13 +3747,13 @@ # fillup parameters UNIVERSAL::isa($_[$param] => 'SOAP::Data') ? $_[$param]->SOAP::Data::value($value) - : UNIVERSAL::isa($_[$param] => 'ARRAY') + : (ref($_[$param] eq 'ARRAY')) ? (@{$_[$param]} = @$value) - : UNIVERSAL::isa($_[$param] => 'HASH') + : (ref($_[$param]) eq 'HASH') ? (%{$_[$param]} = %$value) - : UNIVERSAL::isa($_[$param] => 'SCALAR') + : (ref($_[$param]) eq 'SCALAR') ? (${$_[$param]} = $$value) - : ($_[$param] = $value) + : ($_[$param] = $value); } } }

Wed Nov 17 02:24:32 2010 martin.kutter [...] fen-net.de - Correspondence added

Subject:	Re: [rt.cpan.org #62667] User reported crash; patch supplied
Date:	Wed, 17 Nov 2010 08:24:18 +0100
To:	bug-SOAP-Lite [...] rt.cpan.org
From:	Martin Kutter <martin.kutter [...] fen-net.de>

Hi, the example this bug report tries to run is broken: It only works for hash-based objects (and then it only works when there's no additional constructor logic to perform). This can be easily validated by using a inside-out object for Template. The patch makes SOAP::Lite accept objects as Hash references, which is fundamentally wrong for everything but hash-based objects without a trivial constructor. Actually, the example should never have been published. Best regards, Martin Am Mittwoch, den 03.11.2010, 08:01 -0400 schrieb Nicholas Bamber via RT: Show quoted text

> Wed Nov 03 08:01:29 2010: Request 62667 was acted upon. > Transaction: Ticket created by SILASMONK > Queue: SOAP-Lite > Subject: User reported crash; patch supplied > Broken in: 0.712 > Severity: Critical > Owner: Nobody > Requestors: SILASMONK@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=62667 > > > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=602056 > > "Using the (slightly modified) examples at: > > http://guide.soaplite.com/ > > causes the client to die with: > > Not a HASH reference at /usr/share/perl5/SOAP/Lite.pm line 3755." > > Unterschiede zwischen Dateien-Anlage (hashref_crash.patch) > Author: Ashish Shukla <wahjava@members.fsf.org> > Subject: use 'ref' rather than 'UNIVERSAL::isa' > > --- a/lib/SOAP/Lite.pm > +++ b/lib/SOAP/Lite.pm > @@ -3747,13 +3747,13 @@ > # fillup parameters > UNIVERSAL::isa($_[$param] => 'SOAP::Data') > ? $_[$param]->SOAP::Data::value($value) > - : UNIVERSAL::isa($_[$param] => 'ARRAY') > + : (ref($_[$param] eq 'ARRAY')) > ? (@{$_[$param]} = @$value) > - : UNIVERSAL::isa($_[$param] => 'HASH') > + : (ref($_[$param]) eq 'HASH') > ? (%{$_[$param]} = %$value) > - : UNIVERSAL::isa($_[$param] => 'SCALAR') > + : (ref($_[$param]) eq 'SCALAR') > ? (${$_[$param]} = $$value) > - : ($_[$param] = $value) > + : ($_[$param] = $value); > } > } > }

Wed Nov 17 02:24:33 2010 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 22 06:21:35 2011 MICHIELB [...] cpan.org - Correspondence added

On Wed 17 Nov 2010 02:24:32, martin.kutter@fen-net.de wrote: Show quoted text

> the example this bug report tries to run is broken: It only works for > hash-based objects (and then it only works when there's no additional > constructor logic to perform).

*SNIP* Show quoted text

> Actually, the example should never have been published.

*SNIP I think this means the bug report should be rejected.

Fri Jul 22 06:24:11 2011 MICHIELB [...] cpan.org - Correspondence added

On Fri 22 Jul 2011 06:21:35, MICHIELB wrote: Show quoted text

> I think this means the bug report should be rejected.

OTOH apparently the Debian package maintainer included a patch for this one downstream!

Mon Aug 15 13:17:33 2011 kutterma [...] users.sourceforge.net - Correspondence added

As stated before, the example is erroneous. The patch would break things for code using Moose (just an example). Best Regards, Martin

Mon Aug 15 13:17:35 2011 kutterma [...] users.sourceforge.net - Status changed from 'open' to 'rejected'

Fri May 17 07:22:02 2013 x.guimard [...] free.fr - Correspondence added

Subject:	Re: [rt.cpan.org #62667] User reported crash; patch supplied
Date:	Fri, 17 May 2013 13:21:37 +0200
To:	bug-SOAP-Lite [...] rt.cpan.org
From:	Xavier <x.guimard [...] free.fr>

Hi, as said here: http://bugs.debian.org/602056, UNIVERSAL doc mentions: # but never do this! $is_io = UNIVERSAL::isa($fd, "IO::Handle"); $sub = UNIVERSAL::can($obj, "print"); So maybe we could replace UNIVERSAL::isa($_[$param] => 'ARRAY') by $_[$param]->isa('ARRAY') Cheers, Xavier

Sat May 18 14:32:11 2013 x.guimard [...] free.fr - Correspondence added

Subject:	Re: [rt.cpan.org #62667] User reported crash; patch supplied
Date:	Sat, 18 May 2013 20:31:48 +0200
To:	bug-SOAP-Lite [...] rt.cpan.org
From:	Xavier <x.guimard [...] free.fr>

Hi, looking one more time to the reported problem, it seems that in the broken example $values is a ref to a hashref. I've so written the joined patch. Note the new case: elsif ( reftype( $_[$param] ) eq 'HASH' ) { ... elsif ( reftype($value) eq 'REF' ) { %{ $_[$param] } = %$$value; } } This patch is entirely empirical, but it does run the proposed example.

Message body is not shown because sender requested not to inline it.