Bug #62553 for CatalystX-DebugFilter: Adding DebugFilter stops file uploads being able to be slurped

Fri Oct 29 09:30:15 2010 huggie [...] earth.li - Ticket created

Subject:

Adding DebugFilter stops file uploads being able to be slurped

perl is 5.8.8 Catalyst is 5.80024 DebugFilter is 0.05 I've attached a tarball of a simple Catalyst that once I add DebugFilter to stops working. If I comment out DebugFilter then I don't get that functionality but I do get uploads working. $upload->slurp fails with: [error] Can't open '/tmp/4fOV3ZvP16': 'No such file or directory' Commenting it out once more then it works. I don't understand why one would affect the other. Any help gratefully received.

Subject:

uploadtest.tar.gz

Download uploadtest.tar.gz
application/gzip 104.7k

Message body not shown because it is not plain text.

Fri Oct 29 15:57:27 2010 bpphillips+bitcard [...] gmail.com - Correspondence added

On Fri Oct 29 09:30:15 2010, huggie wrote: Show quoted text

> perl is 5.8.8 > Catalyst is 5.80024 > DebugFilter is 0.05 > > I've attached a tarball of a simple Catalyst that once I add

DebugFilter Show quoted text

> to stops working. > > If I comment out DebugFilter then I don't get that functionality but I > do get uploads working. > > $upload->slurp fails with: > [error] Can't open '/tmp/4fOV3ZvP16': 'No such file or directory' > > Commenting it out once more then it works. > > I don't understand why one would affect the other. Any help

gratefully Show quoted text

> received.

I can definitely see why this might happen but I can't reproduce the problem (even after installing the versions of software you list). Would you be able to experiment with a couple of things on your end? * Try upgrading to CatalystX::DebugFilter 0.06 (this uses Clone::PP instead of Clone::Fast) * Try removing the "clone" step in CatalystX/DebugFilter.pm. Just change this line (http://github.com/brianphillips/CatalystX- DebugFilter/blob/master/lib/CatalystX/DebugFilter.pm#L23) to my $copy = $obj; Let me know if either of those affect the behavior you're seeing. Also, I've added a unit test to CatalystX-DebugFilter that tests this behavior (and it passes on my system). Here's the commit: http://goo.gl/974Q Could you grab the git version and run the unit test on your system and see if it fails?

Fri Oct 29 15:57:28 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 02 05:53:56 2010 huggie [...] earth.li - Correspondence added

From:

huggie [...] earth.li

On Fri Oct 29 15:57:27 2010, bphillips wrote: Show quoted text

> I can definitely see why this might happen but I can't reproduce the > problem (even after installing the versions of software you list). > Would you be able to experiment with a couple of things on your end? > > * Try upgrading to CatalystX::DebugFilter 0.06 (this uses Clone::PP > instead of Clone::Fast) > * Try removing the "clone" step in CatalystX/DebugFilter.pm. Just > change this line (http://github.com/brianphillips/CatalystX- > DebugFilter/blob/master/lib/CatalystX/DebugFilter.pm#L23) to my $copy = > $obj; > > Let me know if either of those affect the behavior you're seeing.

Aha. I had issues originally with Clone::Fast so this might have been a red-herring all along. I got some advice on IRC to change it to Clone and so it's possible your code was never at fault. I can confirm though that 0.06 and Clone::PP work fine.

Tue Nov 02 08:36:52 2010 bpphillips+bitcard [...] gmail.com - Correspondence added

On Tue Nov 02 05:53:56 2010, huggie wrote: Show quoted text

> Aha. I had issues originally with Clone::Fast so this might have been a > red-herring all along. I got some advice on IRC to change it to Clone > and so it's possible your code was never at fault. > > I can confirm though that 0.06 and Clone::PP work fine.

The module was originally released using Clone but a coworker here at $work complained that it was killing database handles when objects in the stash were cloned (when dumping the stash for the debug screen). I changed it to Clone::Fast at his suggestion and then there were a number of issues with Clone::Fast (it segfaults on my laptop all the time) so I changed it to just Clone::PP. I will mark this ticket as resolved but please let me know if you have any other issues with it.

Tue Nov 02 08:36:53 2010 bpphillips+bitcard [...] gmail.com - Status changed from 'open' to 'resolved'