Bug #62518 for Games-Tournament-Swiss: $self->byes->{pairingNumber} but NOT id

Thu Oct 28 10:35:26 2010 vertolet666 [...] yandex.ru - Ticket created

Subject:	$self->byes->{pairingNumber} but NOT id
Date:	Thu, 28 Oct 2010 18:35:11 +0400
To:	bug-games-tournament-swiss [...] rt.cpan.org
From:	DOBRO Sergei <vertolet666 [...] yandex.ru>

Hi,

I noticed that in some lines in FIDE.pm pairingNumber is used for getting byes instead of id.

In sub c13:

line 1348: if ( @$members == 1 and not $self->byes->{$members->[0]->pairingNumber} ) {

line 1357: if ( @$members == 1 and not $self->byes->{$members->[0]->pairingNumber} ) {

Is it correct?

According to the documentation:

"Gets/sets a anonymous hash, keyed on ids, not pairing numbers of players, of a previous round in which these players had a bye. This has probably been calculated by Games::Tournament::Swiss::byes. B1"

Fri Oct 29 00:31:02 2010 drbean [...] freeshell.org - Correspondence added

Subject:	Re: [rt.cpan.org #62518] $self->byes->{pairingNumber} but NOT id
Date:	Fri, 29 Oct 2010 04:30:54 +0000
To:	Семичёв Сергей via RT <bug-Games-Tournament-Swiss [...] rt.cpan.org>
From:	Greg Matheson <drbean [...] freeshell.org>

On Thu, 28 Oct 2010, Семичёв Сергей via RT wrote: Show quoted text

> Thu Oct 28 10:35:26 2010: Request 62518 was acted upon. > Transaction: Ticket created by vertolet666@yandex.ru > Queue: Games-Tournament-Swiss > Subject: $self->byes->{pairingNumber} but NOT id > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: vertolet666@yandex.ru > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=62518 >

Show quoted text

> Hi, I noticed that in some lines in FIDE.pm pairingNumber is used for getting > byes instead of id.In sub c13:line 1348: if ( @$members == 1 and not > $self->byes->{$members->[0]->pairingNumber} ) { line 1357: if ( @$members == 1 > and not $self->byes->{$members->[0]->pairingNumber} ) { Is it correct?

Looks like, here, I have changed that to id, rather than pairingNumber. Try the SVN repository at http://svn.openfoundry.org/swiss/trunk/lib/Games/Tournament/Swiss/Procedure/FIDE.pm Show quoted text

> According to the documentation:"Gets/sets a anonymous hash, keyed on ids, not > pairing numbers of players, of a previous round in which these players had a > bye. This has probably been calculated by Games::Tournament::Swiss::byes. B1"

I must have uploaded a version to CPAN where I hadn't finished that change from pairingNumber to id. It's now more than 1 year old.

Fri Oct 29 00:31:03 2010 The RT System itself - Status changed from 'new' to 'open'