Skip Menu |

This queue is for tickets about the DBD-mysql CPAN distribution.

Report information
The Basics
Id: 62516
Status: resolved
Priority: 0/
Queue: DBD-mysql
People
Owner: CAPTTOFU [...] cpan.org
Requestors: bernt.johnsen [...] oracle.com
Cc: pali [...] cpan.org
AdminCc:
Bug Information
Severity: Normal
Broken in: 4.017
Fixed in: 4.041_01

History Show all quoted text
  Thu Oct 28 09:41:43 2010 bernt.johnsen [...] oracle.com - Ticket created
Subject: mysql_to_perl_type is not thread safe
The local variable enum_type in mysql_to_perl_type is declared static and makes the function non-threadsafe. Easy fix: --- a/dbdimp.c +++ b/dbdimp.c @@ -326,7 +326,7 @@ free_param(imp_sth_ph_t *params, int num_params) static enum enum_field_types mysql_to_perl_type(enum enum_field_types type) { - static enum enum_field_types enum_type; + enum enum_field_types enum_type; switch (type) { case MYSQL_TYPE_DOUBLE:
  Tue Oct 22 08:04:13 2013 MICHIELB [...] cpan.org - Correspondence added
Patrick, can you please take a look at this (very trivial) fix?
  Tue Oct 22 08:04:13 2013 The RT System itself - Status changed from 'new' to 'open'
  Tue Oct 22 08:04:14 2013 MICHIELB [...] cpan.org - Given to CAPTTOFU
  Fri Jan 13 17:07:10 2017 pali [...] cpan.org - Cc PALI added
  Fri Jan 13 17:07:56 2017 pali [...] cpan.org - Correspondence added
On Štv Okt 28 09:41:43 2010, berntm wrote: Show quoted text
> The local variable enum_type in mysql_to_perl_type is declared static > and makes the function non-threadsafe. > > Easy fix: > > --- a/dbdimp.c > +++ b/dbdimp.c > @@ -326,7 +326,7 @@ free_param(imp_sth_ph_t *params, int num_params) > > static enum enum_field_types mysql_to_perl_type(enum enum_field_types type) > { > - static enum enum_field_types enum_type; > + enum enum_field_types enum_type; > > switch (type) { > case MYSQL_TYPE_DOUBLE:
Fixed as part of https://github.com/perl5-dbi/DBD-mysql/pull/67 in 4.041_01.
  Fri Jan 13 17:08:06 2017 pali [...] cpan.org - Fixed in 4.041_01 added
  Fri Mar 03 02:24:13 2017 MICHIELB [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Jul 01 05:11:35 2017 pali [...] cpan.org - Correspondence added
Reopening, fix was reverted in 4.043.
  Sat Jul 01 05:11:40 2017 pali [...] cpan.org - Status changed from 'resolved' to 'open'
  Wed Nov 15 02:49:30 2017 MICHIELB [...] cpan.org - Correspondence added
Ticket migrated to github as https://github.com/perl5-dbi/DBD-mysql/issues/187
  Wed Nov 15 02:49:31 2017 MICHIELB [...] cpan.org - Status changed from 'open' to 'resolved'