Bug #62489 for Redis: ping() dies on disconnect (1.2001)

Wed Oct 27 11:04:04 2010 mjy [...] geizhals.at - Ticket created

Subject:	ping() dies on disconnect (1.2001)
Date:	Wed, 27 Oct 2010 17:03:50 +0200
To:	bug-Redis [...] rt.cpan.org
From:	Marinos Yannikos <mjy [...] geizhals.at>

The ping() method should/could be used to detect server disconnects, but it dies instead of returning false, so it is not very useful: can't read socket: at /usr/local/share/perl/5.10.0/Redis.pm line 120. Regards, Marinos -- Dipl.-Ing. Marinos Yannikos, CEO Preisvergleich Internet Services AG Obere Donaustrasse 63, A-1020 Wien Tel./Fax: (+431) 5811609-52/-55 Handelsgericht Wien - FN 197241K - Firmensitz Wien

Tue Jan 04 16:41:12 2011 brian [...] omniti.com - Correspondence added

Subject:	[rt.cpan.org #62489] Fix for ping
Date:	Tue, 4 Jan 2011 16:40:41 -0500
To:	bug-redis [...] rt.cpan.org
From:	Brian Dunavant <brian [...] omniti.com>

Along with my change in #64472 the following code should cause ping to work like it says it should in the POD documentation and fixes this bug. In AUTOLOAD change the following line from: my $result = <$sock> || die "can't read socket: $!"; to: my $result; eval { $result = <$sock> || $self->__reconnect_and_retry($send) || die "can't read socket: $!"; }; if( $@ ) { return undef if $command eq 'ping'; die $@; }

Tue Jan 04 16:41:13 2011 The RT System itself - Status changed from 'new' to 'open'

Sat Feb 05 07:08:25 2011 melo [...] cpan.org - Taken

Sat Feb 05 07:08:53 2011 melo [...] cpan.org - Correspondence added

Hi, fixed in https://github.com/melo/perl- redis/commit/b40b59522c0266b3f81b407b3ddab4ece7fd7036 Expect a 1.902 release before the end of the day.

Sat Feb 05 07:08:54 2011 melo [...] cpan.org - Status changed from 'open' to 'patched'

Tue Jan 10 09:54:30 2012 melo [...] cpan.org - Correspondence added

Fixed with the release of 1.902. Thanks, -- Hi, how are you?

Tue Jan 10 09:54:31 2012 The RT System itself - Status changed from 'patched' to 'open'

Tue Jan 10 09:54:31 2012 melo [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #62489 for Redis: ping() dies on disconnect (1.2001)

Preferred bug tracker