Bug #62371 for DBD-SQLite: Rollback without a transaction is not considered an error

Fri Oct 22 06:46:13 2010 ribasushi [...] leporine.io - Ticket created

Subject:

Rollback without a transaction is not considered an error

Probably related to RT#62370, but this code executes without a peep, even though it should DIAF: my $dbh = DBI->connect('dbi:SQLite::memory:'); $dbh->{RaiseError} = 1; $dbh->rollback;

Fri Oct 22 06:48:45 2010 ribasushi [...] leporine.io - Correspondence added

Sigh. Apologies, I managed to screw up this report as well. The code in question (with the proper AutoCommit) is: my $dbh = DBI->connect('dbi:SQLite::memory:', undef, undef, { RaiseError => 1, AutoCommit => 1, }); $dbh->rollback; Still passes just fine

Fri Oct 22 06:48:45 2010 ribasushi [...] leporine.io - Status changed from 'new' to 'open'

Wed Nov 03 10:14:55 2010 ishigaki [...] cpan.org - Correspondence added

Try adding PrintWarn => 1 to the attribute hashref. You'll get a "rollback ineffective with AutoCommit enabled" warning, issued by DBI (not by DBD::SQLite). So I think it is not supposed to DIAF in this case. I close this as rejected now, but if you have any pointer that tells me it should DIAF, please reopen this. Thanks. On Fri Oct 22 06:48:45 2010, RIBASUSHI wrote: Show quoted text

> Sigh. Apologies, I managed to screw up this report as well. The code

in Show quoted text

> question (with the proper AutoCommit) is: > > my $dbh = DBI->connect('dbi:SQLite::memory:', undef, undef, { > RaiseError => 1, > AutoCommit => 1, > }); > $dbh->rollback; > > > Still passes just fine

Wed Nov 03 10:14:56 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'rejected'

Wed Nov 03 11:51:04 2010 TIMB [...] cpan.org - Correspondence added

rollback should generate a warning by default: if (DBIc_has(imp_dbh,DBIcf_AutoCommit) && DBIc_WARN(imp_dbh)) warn("rollback ineffective with AutoCommit enabled"); because DBIc_WARN should be true by default. If DBIc_WARN isn't true by default for DBD::SQLite then that's a bug.

Wed Nov 03 11:51:05 2010 The RT System itself - Status changed from 'rejected' to 'open'

Fri Dec 10 01:55:10 2010 ishigaki [...] cpan.org - Correspondence added

DBD::SQLite 1.32_01 should fix this issue. Thanks. On 2010-11-03 Thu 11:51:04, TIMB wrote: Show quoted text

> rollback should generate a warning by default: > > if (DBIc_has(imp_dbh,DBIcf_AutoCommit) && DBIc_WARN(imp_dbh)) > warn("rollback ineffective with AutoCommit enabled"); > > because DBIc_WARN should be true by default. If DBIc_WARN isn't true > by default for DBD::SQLite > then that's a bug.

Fri Dec 10 01:55:11 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'