| Subject: | EUMM minimal version should not be set to the author's installed version |
A META.yml file written by Module::Install sets the minimal EUMM
version to the version as found on the author's system. I think this
approach is wrong, for reasons explained in Ævar's blog post
http://blogs.perl.org/users/aevar_arnfjor_bjarmason/2010/10/the-cpan-client-version-less-dependency-problem.html
(see his update to chromatic's post).
Additionally this code leads to the test error mentioned in
https://rt.cpan.org/Ticket/Display.html?id=62348
I suggest to simply set the minimum EUMM version to 0. This could be
increased if there was really ever a problem with older EUMM. But if
so, this should be documented.
See the attached patch. This closes my today's series of RT tickets
and patches for Module::Install.
Regards,
Slaven
| Subject: | 0001-do-not-force-anymore-the-newest-ExtUtils-MakeMaker-w.patch |
From ce659f08543d9a52e4b63e860fd0acd3e54b6a99 Mon Sep 17 00:00:00 2001
From: Slaven Rezic <slaven@rezic.de>
Date: Thu, 21 Oct 2010 18:43:43 +0200
Subject: [PATCH] do not force anymore the newest ExtUtils::MakeMaker without a good reason
---
lib/Module/Install/Makefile.pm | 19 ++-----------------
1 files changed, 2 insertions(+), 17 deletions(-)
diff --git a/lib/Module/Install/Makefile.pm b/lib/Module/Install/Makefile.pm
index a3fdb00..6f05eee 100644
--- a/lib/Module/Install/Makefile.pm
+++ b/lib/Module/Install/Makefile.pm
@@ -210,23 +210,8 @@ sub write {
. "but we need version >= $perl_version";
}
- # Make sure we have a new enough MakeMaker
- require ExtUtils::MakeMaker;
-
- if ( $perl_version and Module::Install::_cmp($perl_version, '5.006') >= 0 ) {
- # MakeMaker can complain about module versions that include
- # an underscore, even though its own version may contain one!
- # Hence the funny regexp to get rid of it. See RT #35800
- # for details.
- my $v = $ExtUtils::MakeMaker::VERSION =~ /^(\d+\.\d+)/;
- $self->build_requires( 'ExtUtils::MakeMaker' => $v );
- $self->configure_requires( 'ExtUtils::MakeMaker' => $v );
- } else {
- # Allow legacy-compatibility with 5.005 by depending on the
- # most recent EU:MM that supported 5.005.
- $self->build_requires( 'ExtUtils::MakeMaker' => 6.42 );
- $self->configure_requires( 'ExtUtils::MakeMaker' => 6.42 );
- }
+ $self->build_requires( 'ExtUtils::MakeMaker' => 0 );
+ $self->configure_requires( 'ExtUtils::MakeMaker' => 0 );
# Generate the MakeMaker params
my $args = $self->makemaker_args;
--
1.7.0.3