| Subject: | Module::Install::_cmp is a function, not a method |
There are a couple of places where Module::Install::_cmp is called as a
method, but it is really a function. The attached patch fixes the
problem. Note that the patch triggers a problem in the
25_perl_version_from.t test, which I will deal in another ticket.
Regards,
Slaven
| Subject: | 0001-Module-Install-_cmp-is-a-function-not-a-method.patch |
From 59a8ba61a473b25fca46c0a9681874bfc0015c95 Mon Sep 17 00:00:00 2001
From: Slaven Rezic <slaven@rezic.de>
Date: Thu, 21 Oct 2010 17:38:14 +0200
Subject: [PATCH] Module::Install::_cmp is a function, not a method
---
lib/Module/Install/Admin/Metadata.pm | 2 +-
lib/Module/Install/Makefile.pm | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Module/Install/Admin/Metadata.pm b/lib/Module/Install/Admin/Metadata.pm
index 8b27dd1..a17eb65 100644
--- a/lib/Module/Install/Admin/Metadata.pm
+++ b/lib/Module/Install/Admin/Metadata.pm
@@ -141,7 +141,7 @@ sub dump_meta {
$meta->{$key} = { map { @$_ } @{ $val->{$key} } };
}
- if ( $self->_cmp( $meta->{configure_requires}->{'ExtUtils::MakeMaker'}, '6.36' ) >= 0 ) {
+ if ( Module::Install::_cmp( $meta->{configure_requires}->{'ExtUtils::MakeMaker'}, '6.36' ) >= 0 ) {
# Starting from this version ExtUtils::MakeMaker requires perl 5.6
unless ( $perl_version && $self->perl_version($perl_version) >= 5.006 ) {
$meta->{requires}->{perl} = '5.006';
diff --git a/lib/Module/Install/Makefile.pm b/lib/Module/Install/Makefile.pm
index 7dc29f2..a9c8130 100644
--- a/lib/Module/Install/Makefile.pm
+++ b/lib/Module/Install/Makefile.pm
@@ -213,7 +213,7 @@ sub write {
# Make sure we have a new enough MakeMaker
require ExtUtils::MakeMaker;
- if ( $perl_version and $self->_cmp($perl_version, '5.006') >= 0 ) {
+ if ( $perl_version and Module::Install::_cmp($perl_version, '5.006') >= 0 ) {
# MakeMaker can complain about module versions that include
# an underscore, even though its own version may contain one!
# Hence the funny regexp to get rid of it. See RT #35800
--
1.7.0.3