Bug #62249 for Sys-Filesystem: Build failure in the case of missing dependencies should be clearer

Mon Oct 18 22:14:53 2010 Daphne.Pfister [...] genband.com - Ticket created

Subject:

Build failure in the case of missing dependencies should be clearer

Attempt to install this package with CPAN fails with: "Can't be used ($@) - OS not supported or bad maintained?" even if the only problem is one of the modules such as Params::Util not installed. Should this message be updated to suggest installing Params::Util etc? The $@ bit does include the fact that the module Params/Util.pm can not be located, but there is a large amount of extra information between that and the error message. Error Message: ( editted slightly ) Can't be used (Can't locate Params/Util.pm in @INC (@INC contains: ${HOME}/.cpan/build/Sys-Filesystem-1.30-xjKVu7/lib ${HOME}/.cpan/build/Math-Pari-2.01080604-m5vsBG/blib/arch ${HOME}/.cpan/build/Math-Pari-2.01080604-m5vsBG/blib/lib ${TOOLROOT}/perl/5.12.1/lib/site_perl/5.12.1/PA-RISC2.0-thread-multi- LP64 ${TOOLROOT}/perl/5.12.1/lib/site_perl/5.12.1 ${TOOLROOT}/perl/5.12.1/lib/5.12.1/PA-RISC2.0-thread-multi-LP64 ${TOOLROOT}/perl/5.12.1/lib/5.12.1 .) at ${HOME}/.cpan/build/Sys- Filesystem-1.30-xjKVu7/lib/Sys/Filesystem.pm line 41. BEGIN failed--compilation aborted at ${HOME}/.cpan/build/Sys-Filesystem- 1.30-xjKVu7/lib/Sys/Filesystem.pm line 41. Compilation failed in require at Build.PL line 15. ) - OS not supported or bad maintained?No 'Build' created REHSACK/Sys- Filesystem-1.30.tar.gz

Tue Oct 19 10:17:55 2010 REHSACK [...] cpan.org - Correspondence added

I don't care to diff between gamers (who try to install without fulfilled requirements) and unsupported OS in RT. If you would provide a patch, I'm happy to apply it. Jens

Tue Oct 19 10:17:55 2010 The RT System itself - Status changed from 'new' to 'open'

Tue Oct 19 14:04:06 2010 Daphne.Pfister [...] genband.com - Correspondence added

From:

Daphne.Pfister [...] genband.com

On Tue Oct 19 10:17:55 2010, REHSACK wrote: Show quoted text

> I don't care to diff between gamers (who try to install without > fulfilled requirements) and > unsupported OS in RT. > > If you would provide a patch, I'm happy to apply it. > > Jens

My thought is moving the requires to configure_requires in META.yml should cause CPAN to follow the dependencies before doing the perl Build.PL step. i.e. something like the attached patch, though I haven't been able to test it yet.

Subject:

Sys-Filesystem-Requires.patch

diff -U3 -r Sys-Filesystem-1.30/META.yml Sys-Filesystem/META.yml --- Sys-Filesystem-1.30/META.yml 2010-07-15 15:33:42.000000000 -0400 +++ Sys-Filesystem/META.yml 2010-10-19 13:45:45.000000000 -0400 @@ -6,6 +6,12 @@ Test::More: 0.9 configure_requires: Module::Build: 0.36 + Carp: 0 + FindBin: 0 + IO: 0 + Module::Pluggable: 3.9 + Params::Util: 1.00 + perl: 5.008 generated_by: 'Module::Build version 0.3607' license: apache meta-spec:

Wed Oct 20 03:14:41 2010 REHSACK [...] cpan.org - Correspondence added

On Tue Oct 19 14:04:06 2010, daphnepfister wrote: Show quoted text

> My thought is moving the requires to configure_requires in META.yml > should cause CPAN to > follow the dependencies before doing the perl Build.PL step.

Good point, 1:0 for you ;) Show quoted text

> i.e. something like the attached patch, though I haven't been able to > test it yet.

I'll have a look (but not early - to much todo) Jens

Tue Sep 03 08:11:53 2013 REHSACK [...] cpan.org - Correspondence added

Fixed and uploaded. Thanks a lot

Tue Sep 03 08:11:53 2013 REHSACK [...] cpan.org - Status changed from 'open' to 'resolved'