Bug #62152 for DBD-Oracle: t/28array_bind.t and t/31lob.t may call plan() twice

Thu Oct 14 17:04:24 2010 jand [...] ActiveState.com - Ticket created

Subject:	t/28array_bind.t and t/31lob.t may call plan() twice
Date:	Thu, 14 Oct 2010 14:04:17 -0700
To:	<bug-DBD-Oracle [...] rt.cpan.org>
From:	"Jan Dubois" <jand [...] activestate.com>

Both these tests use a line like this: use Test::More tests => 12; but then later on may still decide to skip all tests with e.g. plan skip_all => "Not connected to oracle" if not $dbh; This doesn't skip the test but will actually generate a failure. The fix is simply to move the regular plan() call beyond the point where the whole test still may need to be skipped (there are lots of other tests in t/* that already do this correctly). Cheers, -Jan

Fri Dec 17 10:33:48 2010 bohica [...] ntlworld.com - Correspondence added

On Thu Oct 14 17:04:24 2010, jand@ActiveState.com wrote: Show quoted text

> Both these tests use a line like this: > > use Test::More tests => 12; > > but then later on may still decide to skip all tests with e.g. > > plan skip_all => "Not connected to oracle" if not $dbh; > > This doesn't skip the test but will actually generate a failure. > > The fix is simply to move the regular plan() call beyond the > point where the whole test still may need to be skipped (there > are lots of other tests in t/* that already do this correctly). > > Cheers, > -Jan >

Thanks Jan. As usual you've done all the work of identifying the problem and I have committed the change into my branch on DBD::Oracle. I cannot say which release it will be in as yet as I need to liaise with the other maintainer. Martin -- Martin J. Evans Wetherby, UK

Fri Dec 17 10:33:49 2010 The RT System itself - Status changed from 'new' to 'open'

Fri Dec 17 16:09:20 2010 champoux [...] pythian.com - Correspondence added

It took the opportunity to go through them all and then all will skip if they cannot connect; Sort of useless though as the first test will croak if it cannot connect as it should because it would not be much of a test if it cannot connect to a DB one would just see all sorts of skips I guess it is useful if the connection is terminated half way though I guess?? Anyway it is just good house cleaning so and can find the source here http://svn.perl.org/modules/dbd-oracle/trunk It will be release with DBD::Oracle 1.28

Fri Dec 17 16:09:21 2010 champoux [...] pythian.com - Status changed from 'open' to 'resolved'

Bug #62152 for DBD-Oracle: t/28array_bind.t and t/31lob.t may call plan() twice

Preferred bug tracker