Skip Menu |

This queue is for tickets about the HTML-Entities-ImodePictogram CPAN distribution.

Report information
The Basics
Id: 62102
Status: new
Priority: 0/
Queue: HTML-Entities-ImodePictogram
People
Owner: Nobody in particular
Requestors: crime.and.penalty [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Oct 13 04:48:17 2010 crime.and.penalty [...] gmail.com - Ticket created
Subject: lacks "OK" pictogram
Hi I think this module lacks "OK" pictogram in docomo basic pictogram. cf ) http://www.nttdocomo.co.jp/service/imode/make/content/pictograph/basic/ No.135 "OK" Unicode: E70B Then I wrote a patch. Could you check an attached patch and merge it to trunk if it would make sense. My best regards, Naoki Watanabe
Subject: add_ok_pictgram.patch
diff -Naru HTML-Entities-ImodePictogram-0.06.orig/lib/HTML/Entities/ImodePictogram.pm HTML-Entities-ImodePictogram-0.06/lib/HTML/Entities/ImodePictogram.pm --- HTML-Entities-ImodePictogram-0.06.orig/lib/HTML/Entities/ImodePictogram.pm 2003-06-24 01:46:42.000000000 +0900 +++ HTML-Entities-ImodePictogram-0.06/lib/HTML/Entities/ImodePictogram.pm 2010-10-13 16:14:43.000000000 +0900 @@ -96,7 +96,7 @@ ($cp >= 59052 && $cp <= 59066) || ($cp >= 59086 && $cp <= 59098)) { return $cp + 4772; - } elsif (($cp >= 59099 && $cp <= 59146) || + } elsif (($cp >= 59099 && $cp <= 59147) || ($cp >= 59148 && $cp <= 59223)) { return $cp + 4773; } else { diff -Naru HTML-Entities-ImodePictogram-0.06.orig/t/00_pictogram.t HTML-Entities-ImodePictogram-0.06/t/00_pictogram.t --- HTML-Entities-ImodePictogram-0.06.orig/t/00_pictogram.t 2002-08-05 22:07:36.000000000 +0900 +++ HTML-Entities-ImodePictogram-0.06/t/00_pictogram.t 2010-10-13 16:14:54.000000000 +0900 @@ -3,9 +3,9 @@ use HTML::Entities::ImodePictogram qw(:all); -# ¤Æ¤¹¤È[À²¤ì][ÆÞ¤ê]¤Æ¤¹¤È -my $raw = "\x82\xc4\x82\xb7\x82\xc6\xf8\x9f\xf8\xa0\x82\xc4\x82\xb7\x82\xc6"; -my $html = "\x82\xc4\x82\xb7\x82\xc6&#63647;&#63648;\x82\xc4\x82\xb7\x82\xc6"; +# ¤Æ¤¹¤È[À²¤ì][ÆÞ¤ê][OK]¤Æ¤¹¤È +my $raw = "\x82\xc4\x82\xb7\x82\xc6\xf8\x9f\xf8\xa0\xf9\xb0\x82\xc4\x82\xb7\x82\xc6"; +my $html = "\x82\xc4\x82\xb7\x82\xc6&#63647;&#63648;&#63920;\x82\xc4\x82\xb7\x82\xc6"; is(encode_pictogram($raw), $html); is(decode_pictogram($html), $raw); @@ -15,9 +15,9 @@ my(@bin, @num); my $num_found = find_pictogram($text, sub { push @bin, $_[0]; push @num, $_[1]; }); -is_deeply \@bin, ["\xf8\x9f", "\xf8\xa0"]; -is_deeply \@num, [ 63647, 63648 ]; -is($num_found, 2); +is_deeply \@bin, ["\xf8\x9f", "\xf8\xa0", "\xf9\xb0"]; +is_deeply \@num, [ 63647, 63648, 63920 ]; +is($num_found, 3);