Skip Menu |

This queue is for tickets about the Catalyst-Plugin-Session-State-Stash CPAN distribution.

Report information
The Basics
Id: 62090
Status: resolved
Priority: 0/
Queue: Catalyst-Plugin-Session-State-Stash
People
Owner: Nobody in particular
Requestors: IKEGAMI [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.14

History Show all quoted text
  Tue Oct 12 17:53:19 2010 IKEGAMI [...] cpan.org - Ticket created
Subject: setup_session doesn't chain
When using two State objects, State-Stash prevents others from initalising properly depending on they are added to the app. Could you please change sub setup_session { my $c = shift; $c->_session_plugin_config->{stash_key} ||= '_session'; } to sub setup_session { my $c = shift; $c->maybe::next::method(@_); $c->_session_plugin_config->{stash_key} ||= '_session'; } Thanks.
  Tue Oct 12 18:00:42 2010 ELPENGUIN [...] cpan.org - Correspondence added
On Tue Oct 12 17:53:19 2010, ikegami wrote: Show quoted text
> When using two State objects, State-Stash prevents others from > initalising properly depending on they are added to the app.
This module is deprecated and is a very bad idea indeed. Please tell me you are not using it. --James
  Tue Oct 12 18:00:43 2010 The RT System itself - Status changed from 'new' to 'open'
  Tue Oct 12 18:23:09 2010 IKEGAMI [...] cpan.org - Correspondence added
On Tue Oct 12 18:00:42 2010, ELPENGUIN wrote: Show quoted text
> On Tue Oct 12 17:53:19 2010, ikegami wrote:
> > When using two State objects, State-Stash prevents others from > > initalising properly depending on they are added to the app.
> > This module is deprecated and is a very bad idea indeed. Please tell me > you are not using it.
Sorry, we are. It's not documented as being deprecated. What's wrong with it? We use it purely to get the session id from a form field for some of our requests: sub auto :Private { my ($self, $c) = @_; if (my $session_id = delete($c->req->params->{sid})) { $c->stash->{_session}{id} = $session_id; } return 1; } The plugin isn't used to communicate the session id to the user. $c->stash({ current_view => 'XML', response_type => '...', session_id => $c->sessionid, ... }); - Eric
  Tue Oct 12 18:39:19 2010 ELPENGUIN [...] cpan.org - Correspondence added
On Tue Oct 12 18:23:09 2010, ikegami wrote: Show quoted text
> Sorry, we are. It's not documented as being deprecated. What's wrong > with it? > > We use it purely to get the session id from a form field for some of our > requests: > > sub auto :Private { > my ($self, $c) = @_; > if (my $session_id = delete($c->req->params->{sid})) { > $c->stash->{_session}{id} = $session_id; > } > > return 1; > } > > The plugin isn't used to communicate the session id to the user. > > $c->stash({ > current_view => 'XML', > response_type => '...', > session_id => $c->sessionid, > ... > }); > > - Eric
If it's actually useful to you, by all means please feel free to use it. I wrote this during a period when I was playing with stateful web services, which I later decided were a very bad idea, hence why I disrecommend its use, but if it's useful for your project/business, go mad. I had thought I'd put a big deprecated/not-maintained notice on it, but apparently I haven't, so sorry for the confusion there. As you have provided a patch, I've merged it into the git tree ( http://github.com/jjl/Catalyst--Plugin--Session--State--Stash , which works with more recent catalysts as well). I don't use this module myself anymore. Would you like a MAINT bit on PAUSE for it? --James
  Tue May 17 16:42:13 2011 ELPENGUIN [...] cpan.org - Correspondence added
IKEGAMI -- I'm not maintaining this anymore. Would you like MAINT on PAUSE? As noted, the patch was merged into github. Cheers
  Mon Oct 24 19:43:52 2011 bobtfish [...] bobtfish.net - Status changed from 'open' to 'resolved'
  Tue Jul 07 21:21:49 2015 ether [...] cpan.org - Correspondence added
On 2011-05-17 13:42:13, ELPENGUIN wrote: Show quoted text
> IKEGAMI -- I'm not maintaining this anymore. Would you like MAINT on > PAUSE? As noted, the > patch was merged into github. > > Cheers
Released in 0.14.
  Wed Jul 08 11:25:39 2015 ether [...] cpan.org - Fixed in 0.14 added