Bug #61858 for Slay-Makefile-Gress: bleadperl fb85c044 breaks S:M:G with (?^...) regex construct

Sat Oct 02 23:40:20 2010 ANDK [...] cpan.org - Ticket created

Subject:

bleadperl fb85c044 breaks S:M:G with (?^...) regex construct

Perl 5.13 recently changed the stringification of regexps. This broke your tests because they expect the "-xism" part of the old stringification. The new stringification starts with (?^ See also http://rt.perl.org/rt3/Ticket/Display.html?id=78008 HTH, Regards,

Sat Dec 04 05:22:02 2010 ANDK [...] cpan.org - Correspondence added

I've uploaded a patch to CPAN that on the fly rewrites the expectations when the perl is more recent than the qr// stringification change. ftp://cpan.cpantesters.org/CPAN/authors/id/A/AN/ANDK/patches/Slay-Makefile-Gress-0.07-ANDK-01.patch.gz A distroprefs file that instructe the CPAN shell to download and apply this patch is at https://github.com/andk/cpanpm/blob/master/distroprefs/NODINE.Slay-Makefile-Gress.yml Hope you like it, enjoy.

Sat Dec 04 05:22:03 2010 ANDK [...] cpan.org - Status changed from 'new' to 'open'

Tue Dec 07 17:28:00 2010 nodine [...] cpan.org - Correspondence added

Thanks for the patch. Can you test the attached patch to see if it works (it also tries to fix some other failures I've seen)? Thanks.

Subject:

Slay-Makefile-Gress-0.07-NODINE-01.patch

--- t/30_options.init/Dir.smak 2009-08-31 14:53:55.000000000 -0500 +++ t/30_options.init/Dir.smak 2010-12-07 16:16:27.745406000 -0600 @@ -5,11 +5,14 @@ } %.ok: %.out.exp %.out - diff -i $DEP0 $DEP1 > $TARGET + diff -iu $DEP0 $DEP1 > $TARGET %.out: { my ($maker, $target, $deps, $matches) = @_; my $dbg = $ENV{DEBUG} ? '-d ' : ''; - system "$^X $dbg-I../../blib/lib $matches->[0].t 2>&1 | grep -v Gress.pm | egrep . > $target"; + system "$^X $dbg-I../../blib/lib $matches->[0].t 2>&1 | + $^X -ne 's/\\\\n/\\n/g; + s/\\?^:/?-xism:/; + print if !/Gress.pm/ && /./' > $target"; }

Wed Dec 08 02:57:02 2010 ANDK [...] cpan.org - Correspondence added

The patch doesn't work for the first perl I tried it on. May I suggest you make devel releases to try out different approaches? They are tested within a much shorter timeframe on more platforms than I can do it manually. Thanks!

Wed Dec 08 10:56:48 2010 nodine [...] cpan.org - Correspondence added

On Wed Dec 08 02:57:02 2010, ANDK wrote: Show quoted text

> The patch doesn't work for the first perl I tried it on. May I suggest > you make devel releases to try out different approaches? They are tested > within a much shorter timeframe on more platforms than I can do it

manually. I'm not sure how to do a devel release.

Wed Dec 08 14:51:21 2010 ANDK [...] cpan.org - Correspondence added

Oh I'm sorry I didn't explain. Nowadays, at least among the younger people, the preferred form is this: RIBASUSHI/DBIx-Class-0.08124-TRIAL.tar.gz GETTY/Text-Socialize-0.001-TRIAL.tar.gz ILMARI/multidimensional-0.003-TRIAL.tar.gz ILMARI/Class-Unload-0.06-TRIAL.tar.gz GENEHACK/WebService-FitBit-0.1-TRIAL.tar.gz GENEHACK/App-GitGitr-0.1-TRIAL.tar.gz RWSTAUNER/Git-DescribeVersion-0.004008-TRIAL.tar.gz RWSTAUNER/Git-DescribeVersion-0.005011-TRIAL.tar.gz DOY/Package-Stash-XS-0.16-TRIAL.tar.gz DOY/Package-Stash-XS-0.15-TRIAL.tar.gz DOY/Package-Stash-0.15-TRIAL.tar.gz FREDERICD/Marc-0.001-TRIAL.tar.gz FREDERICD/Marc-0.002-TRIAL.tar.gz DOY/Package-Stash-0.14-TRIAL.tar.gz In the olde days there was only this form: BIGPRESH/Dancer-Plugin-Database-0.12_01.tar.gz KJETILK/RDF-LinkedData-0.15_2.tar.gz JKEGL/Marpa-XS-0.001_015.tar.gz SCHUBIGER/Math-Prime-XS-0.22_01.tar.gz SGRAHAM/Template-Benchmark-1.09_01.tar.gz BIGPRESH/Dancer-Plugin-Database-0.12_01.tar.gz DAGOLDEN/Module-Build-0.36_19.tar.gz XSAWYERX/Dancer-1.2002_01.tar.gz KJETILK/RDF-LinkedData-0.15_1.tar.gz SCHUBIGER/DateTime-Format-Natural-0.91_02.tar.gz JMERELO/Algorithm-Evolutionary-0.74_2.tar.gz JJSCHUTZ/Sphinx-Search-0.25_01.tar.gz DAGOLDEN/CPAN-Reporter-1.18_06.tar.gz ADAMK/YAML-Tiny-1.45_02.tar.gz BLOONIX/Log-Handler-0.68_01.tar.gz BDFOY/CPAN-Mini-Inject-0.27_03.tar.gz Both variants are valid ways to express that the file contains a developer release that means that it will not be indexed but it will be tested by the cpantesters and can be installed by the enduser with the cpan shells if she specifies the full name of the distro as written above. And the recipe in the first group is: append the string "-TRIAL" to the version number in the filename of your tarball. The second group follows the recipe: anywhere between two digits in the filename of the tarball insert an underscore. Enjoy,

Wed Dec 08 15:32:49 2010 nodine [...] cpan.org - Correspondence added

On Wed Dec 08 02:57:02 2010, ANDK wrote: Show quoted text

> The patch doesn't work for the first perl I tried it on. May I suggest > you make devel releases to try out different approaches? They are

tested Show quoted text

> within a much shorter timeframe on more platforms than I can do it > manually.

I think I see what was wrong with my previous patch. Is there any chance you could try out this version, just on one perl that previously failed? Thanks. (Sorry, I sent this before I got any response about devel releases.)

Subject:

Slay-Makefile-Gress-0.07-NODINE-02.patch

--- t/30_options.init/Dir.smak 2009-08-31 14:53:55.000000000 -0500 +++ t/30_options.init/Dir.smak 2010-12-07 16:16:27.745406000 -0600 @@ -5,11 +5,14 @@ } %.ok: %.out.exp %.out - diff -i $DEP0 $DEP1 > $TARGET + diff -iu $DEP0 $DEP1 > $TARGET %.out: { my ($maker, $target, $deps, $matches) = @_; my $dbg = $ENV{DEBUG} ? '-d ' : ''; - system "$^X $dbg-I../../blib/lib $matches->[0].t 2>&1 | grep -v Gress.pm | egrep . > $target"; + system "$^X $dbg-I../../blib/lib $matches->[0].t 2>&1 | + $^X -ne 's/\\\\n/\\n/g; + s/\\?\\^:/?-xism:/; + print if !/Gress.pm/ && /./' > $target"; }

Thu Dec 09 00:26:36 2010 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org
Subject:	Re: [rt.cpan.org #61858] bleadperl fb85c044 breaks S:M:G with (?^...) regex construct
Date:	Thu, 09 Dec 2010 06:26:14 +0100
To:	bug-Slay-Makefile-Gress [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Wed, 8 Dec 2010 15:32:50 -0500, "Mark Nodine via RT" <bug-Slay-Makefile-Gress@rt.cpan.org> said:

Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=61858 > > On Wed Dec 08 02:57:02 2010, ANDK wrote:

>> The patch doesn't work for the first perl I tried it on. May I suggest >> you make devel releases to try out different approaches? They are

> tested

>> within a much shorter timeframe on more platforms than I can do it >> manually.

Show quoted text

> I think I see what was wrong with my previous patch. Is there any > chance you could try out this version, just on one perl that previously > failed?

Show quoted text

> Thanks. (Sorry, I sent this before I got any response about devel > releases.) > --- t/30_options.init/Dir.smak 2009-08-31 14:53:55.000000000 -0500 > +++ t/30_options.init/Dir.smak 2010-12-07 16:16:27.745406000 -0600 > @@ -5,11 +5,14 @@ > }

Show quoted text

> %.ok: %.out.exp %.out > - diff -i $DEP0 $DEP1 > $TARGET > + diff -iu $DEP0 $DEP1 > $TARGET

Show quoted text

> %.out: > { my ($maker, $target, $deps, $matches) = @_; > my $dbg = $ENV{DEBUG} ? '-d ' : ''; > - system "$^X $dbg-I../../blib/lib $matches->[0].t 2>&1 | grep -v Gress.pm | egrep . > $target"; > + system "$^X $dbg-I../../blib/lib $matches->[0].t 2>&1 | > + $^X -ne 's/\\\\n/\\n/g; > + s/\\?\\^:/?-xism:/; > + print if !/Gress.pm/ && /./' > $target"; > }

Works! -- andreas