Skip Menu |

This queue is for tickets about the HTML-Tree CPAN distribution.

Report information
The Basics
Id: 61857
Status: resolved
Priority: 0/
Queue: HTML-Tree
People
Owner: Jeff.Fearn [...] gmail.com
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 4.0
Fixed in: 4.1

History Show all quoted text
  Sat Oct 02 22:13:22 2010 ANDK [...] cpan.org - Ticket created
Subject: Fails if Perl-Critic-Compatibility is installed
As per subject. Example of a failing test report: http://www.cpantesters.org/cpan/report/8601178 I believe Test::Perl::Critic tests should be author tests because they may uncover bugs but they may also just uncover violations of principles that are not critical (sic!). Regards,
  Tue Oct 12 08:20:35 2010 Jeff.Fearn [...] gmail.com - Taken
  Tue Oct 12 08:29:08 2010 Jeff.Fearn [...] gmail.com - Correspondence added
On Sun Oct 03 12:13:22 2010, ANDK wrote: Show quoted text
> As per subject. > > Example of a failing test report: > > http://www.cpantesters.org/cpan/report/8601178 > > I believe Test::Perl::Critic tests should be author tests because they > may uncover bugs but they may also just uncover violations of principles > that are not critical (sic!).
Hi, 4.0 was a pretty heavy change-set and I've found enabling the tests on cpan testers to be invaluable. I'd rather leave them enabled ATM and fix issues as they arise. I already excluded ProhibitAccessOfPrivateData which was giving bogus results. In this case the test checks the module for which perl to use, but not any restrictions in the Build or Makefiles, perhaps there are other places this is also true. I think it's best to duplicate the use from the Build file in Parse.pm. http://github.com/jfearn/HTML-Tree/commit/457efcf65b51fabf42492a8d6e335b2d14d7101a Tests fine with Perl-Critic-Compatibility installed now. Thanks for the report! Cheers, Jeff.
  Tue Oct 12 08:29:09 2010 The RT System itself - Status changed from 'new' to 'open'
  Tue Oct 12 08:29:09 2010 Jeff.Fearn [...] gmail.com - Status changed from 'open' to 'patched'
  Tue Oct 26 04:05:29 2010 Jeff.Fearn [...] gmail.com - Fixed in 4.1 added
  Tue Oct 26 04:05:29 2010 Jeff.Fearn [...] gmail.com - Correspondence added
Version 4.1 shipped with a fix for this bug.
  Tue Oct 26 04:05:29 2010 The RT System itself - Status changed from 'patched' to 'open'
  Tue Oct 26 04:05:30 2010 Jeff.Fearn [...] gmail.com - Status changed from 'open' to 'resolved'