Bug #6183 for Net-Google: Broken test-case in Net::Google::Spelling

Sat May 01 13:20:51 2004 Guest - Ticket created

Subject:

Broken test-case in Net::Google::Spelling - with patch

Net::Google::Spelling 0.61 contains a test case that fails when run under perl 5.6 on FreeBSD 5.2.1. This bug is platform and perl version indepandant. The test case has been indexed by google, and since the test phrase is not particularly popular, it has become a suggestion of its own in the spelling test. The solution is to use only phrases that appear in the Google Zeitgeist of popular search phrases, so that even when it is indexed, the correct term remains more popular than the incorrect term used for testing. Attached patch does this for current results. For updates, please use the Zeigeist, which can be found here: http://www.google.com/press/zeitgeist.html

Wed Jun 02 09:33:48 2004 ascope [...] cpan.org - Correspondence added

Thanks, this has been fixed in Net::Google 0.62 which will be released shortly. It appears that the RT system ate your patch but hopefully I have updated the test to use a sufficient popular term ("new york city") that it won't be a problem anymore. Cheers, [guest - Sat May 1 13:20:51 2004]: Show quoted text

> Net::Google::Spelling 0.61 contains a test case that fails when run > under perl 5.6 on FreeBSD 5.2.1. This bug is platform and perl > version indepandant. > > The test case has been indexed by google, and since the test phrase is > not particularly popular, it has become a suggestion of its own in > the spelling test. > > The solution is to use only phrases that appear in the Google > Zeitgeist of popular search phrases, so that even when it is > indexed, the correct term remains more popular than the incorrect > term used for testing. > > Attached patch does this for current results. For updates, please use > the Zeigeist, which can be found here: > http://www.google.com/press/zeitgeist.html

Wed Jun 02 09:33:49 2004 ascope [...] cpan.org - Status changed from 'new' to 'resolved'

Wed Jun 02 09:49:58 2004 Guest - Correspondence added

[ASCOPE - Wed Jun 2 09:33:48 2004]: Show quoted text

> It appears that the RT system ate your patch but hopefully I have > updated the test to use a sufficient popular term ("new york city") > that > it won't be a problem anymore. >

My patch looks like this: 002-spelling.t Sat May 1 18:16:25 2004 +++ ../../Net-Google-0.61-orig/t/002-spelling.t Sat Nov 2 05:07:09 2002 @@ -3,8 +3,8 @@ use constant TMPFILE => "./blib/google-api.key"; -use constant WRONG => "southwset arilines"; -use constant CORRECT => "southwest airlines"; +use constant WRONG => "muntreal qweebec"; +use constant CORRECT => "montreal quebec"; my $key = $ARGV[0]; It should do exactly the same as yours.

Wed Jun 02 09:50:06 2004 The RT System itself - Status changed from 'resolved' to 'open'

Wed Jun 02 10:27:15 2004 ascope [...] cpan.org - Correspondence added

Thanks, [guest - Wed Jun 2 09:49:58 2004]: Show quoted text

> [ASCOPE - Wed Jun 2 09:33:48 2004]: >

> > It appears that the RT system ate your patch but hopefully I have > > updated the test to use a sufficient popular term ("new york city") > > that > > it won't be a problem anymore. > >

> > My patch looks like this: > > 002-spelling.t Sat May 1 18:16:25 2004 > +++ ../../Net-Google-0.61-orig/t/002-spelling.t Sat Nov 2 05:07:09 > 2002 > @@ -3,8 +3,8 @@ > > > use constant TMPFILE => "./blib/google-api.key"; > -use constant WRONG => "southwset arilines"; > -use constant CORRECT => "southwest airlines"; > +use constant WRONG => "muntreal qweebec"; > +use constant CORRECT => "montreal quebec"; > > my $key = $ARGV[0]; > > > It should do exactly the same as yours.

Wed Jun 02 10:27:16 2004 ascope [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #6183 for Net-Google: Broken test-case in Net::Google::Spelling - with patch