Bug #61776 for Test-Trap: removal of temporary files

Wed Sep 29 16:41:16 2010 Ian.Goodacre [...] xtra.co.nz - Ticket created

Subject:

removal of temporary files

After the trap has sprung, temporary files are left behind. They will be removed by File::Temp when the process terminates but in the mean time they persist. This is problematic in test scripts attempting to test that temporary files are not left behind. This is easily fixed by unlinking $file in the Teardown sub after closing $fh. With this change, after the trap is sprung, the temporary files are gone. Of course, I am assuming the file isn't used after the Teardown sub has closed the file handle.

Thu Sep 30 01:51:51 2010 Ian.Goodacre [...] xtra.co.nz - Correspondence added

From:

Ian.Goodacre [...] xtra.co.nz

I patched Test::Trap::Builder::TempFile.pm as follows: --- TempFile.pm.orig 2010-09-30 18:48:45.000000000 +1300 +++ TempFile.pm 2010-09-30 09:35:28.000000000 +1300 @@ -20,6 +20,7 @@ local $/; $self->{$name} .= <$fh>; close $fh; + unlink $file; }; binmode $fh; # superfluos? local *$globref;

Fri Apr 08 17:56:49 2011 ebhanssen [...] allverden.no - Correspondence added

On Wed Sep 29 16:41:16 2010, iang wrote: Show quoted text

> After the trap has sprung, temporary files are left behind. They will be > removed by File::Temp when the process terminates but in the mean time > they persist. This is problematic in test scripts attempting to test > that temporary files are not left behind. > > This is easily fixed by unlinking $file in the Teardown sub after > closing $fh. With this change, after the trap is sprung, the temporary > files are gone. Of course, I am assuming the file isn't used after the > Teardown sub has closed the file handle.

Thank you; that's a sensible request, and your patch is a good one. (I've patched Test::Trap::Builder::SystemSafe.pm analogously.) Sorry I have been late in responding; this seems to have fallen through the cracks for me – I only found it as I was rounding up tagalongs for an upcoming bugfix release. (Just need a regression test for that. And on that thought, I probably should write one for this as well ...) -- Eirik Berg Hanssen, ebhanssen@cpan.org Just this .sig then nothing more

Fri Apr 08 17:56:50 2011 The RT System itself - Status changed from 'new' to 'open'

Fri Apr 08 18:03:00 2011 ebhanssen [...] allverden.no - Taken

Thu Mar 01 21:27:26 2012 ebhanssen [...] allverden.no - Correspondence added

I have at long last made a new release, incorporating this fix. Sorry it took so long.

Thu Mar 01 21:27:27 2012 ebhanssen [...] allverden.no - Status changed from 'open' to 'resolved'