Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 6176
Status: resolved
Worked: 3 hours (180 min)
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: ETJ [...] cpan.org
Requestors: Marek.Rouchal [...] gmx.net
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: 7.05_06



Subject: more flexible Mkbootstrap
While hacking at an Extension, I wanted to just pass through code using $bscode from the *_BS to the *.bs file - that did not work, because the @all array was empty. The following patch corrects the problem. Cheers, Marek --- Mkbootstrap.pm.orig 2004-04-22 17:21:52.618068000 +0200 +++ Mkbootstrap.pm 2004-04-29 16:04:50.884816000 +0200 @@ -40,7 +40,7 @@ my(@all) = (@bsloadlibs, @DynaLoader::dl_resolve_using); my($method) = ''; - if (@all){ + if (@all || length $DynaLoader::bscode){ open BS, ">$baseext.bs" or die "Unable to open $baseext.bs: $!"; print STDOUT "Writing $baseext.bs\n"; @@ -49,14 +49,16 @@ print BS "# Do not edit this file, changes will be lost.\n"; print BS "# This file was automatically generated by the\n"; print BS "# Mkbootstrap routine in ExtUtils::Mkbootstrap (v$VERSION).\n"; - print BS "\@DynaLoader::dl_resolve_using = "; - # If @all contains names in the form -lxxx or -Lxxx then it's asking for - # runtime library location so we automatically add a call to dl_findfile() - if (" @all" =~ m/ -[lLR]/){ + if(@all) { + print BS "\@DynaLoader::dl_resolve_using = "; + # If @all contains names in the form -lxxx or -Lxxx then it's asking for + # runtime library location so we automatically add a call to dl_findfile() + if (" @all" =~ m/ -[lLR]/){ print BS " dl_findfile(qw(\n @all\n ));\n"; - }else{ + }else{ print BS " qw(@all);\n"; - } + } + } # write extra code if *_BS says so print BS $DynaLoader::bscode if $DynaLoader::bscode; print BS "\n1;\n";
http://www.makemaker.org/wiki/index.cgi?ModulesForSale ExtUtils::Mkbootstrap is up for sale to be separated out of MakeMaker, so I'm going to leave this patch for whomever the poor sap is that takes over that module. Since you've expressed interest in the module and the skills to patch it, would you like it?
Given this module is still part of EUMM, was the change ever incorporated?
It was not. It is now part of https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/pull/179 along with tests.
On Sat Jan 03 21:38:01 2015, ETJ wrote: Show quoted text
> Patched in https://github.com/Perl-Toolchain-Gang/ExtUtils- > MakeMaker/commit/7f5e9a35addeea7ebfcded28277c85f723e1a5de