Skip Menu |

This queue is for tickets about the DBD-Pg CPAN distribution.

Report information
The Basics
Id: 61713
Status: resolved
Priority: 0/
Queue: DBD-Pg

People
Owner: greg [...] turnstep.com
Requestors: ilmari [...] ilmari.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.18.0



Subject: Test failure with PostgreSQL 7.4.29
Date: Tue, 28 Sep 2010 02:12:43 +0200
To: bug-DBD-Pg [...] rt.cpan.org
From: ilmari [...] ilmari.org (Dagfinn Ilmari Mannsåker)
I get an error in the placeholder tests with PostgreSQL 7.4.29, with both DBI version 1.609 and 1.615: t/12placeholders.t .. 1/235 # Failed test 'Calling do() with invalid crowded placeholders fails cleanly' # at t/12placeholders.t line 434. # got: '' # expected: '42601' # Looks like you failed 1 test of 235. t/12placeholders.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/235 subtests (less 17 skipped subtests: 217 okay) Attached is the full build log. -- ilmari "A disappointingly low fraction of the human race is, at any given time, on fire." - Stig Sandbeck Mathisen
ilmari@nurket:~/src/DBD-Pg$ perl Makefile.PL Configuring DBD::Pg 2.17.1 PostgreSQL version: 70429 (default port: 5432) POSTGRES_HOME: /usr/local/postgresql/REL7_4_29/ POSTGRES_INCLUDE: /usr/local/postgresql/REL7_4_29/include POSTGRES_LIB: /usr/local/postgresql/REL7_4_29/lib OS: linux Checking if your kit is complete... Looks good Using DBI 1.609 (for perl 5.010001 on x86_64-linux-gnu-thread-multi) installed in /usr/lib/perl5/auto/DBI/ Writing Makefile for DBD::Pg ilmari@nurket:~/src/DBD-Pg$ make test cp lib/Bundle/DBD/Pg.pm blib/lib/Bundle/DBD/Pg.pm cp Pg.pm blib/lib/DBD/Pg.pm /usr/bin/perl -p -e "s/~DRIVER~/Pg/g; s/^do\(/dontdo\(/" /usr/lib/perl5/auto/DBI/Driver.xst > Pg.xsi /usr/bin/perl /usr/share/perl/5.10/ExtUtils/xsubpp -typemap /usr/share/perl/5.10/ExtUtils/typemap Pg.xs > Pg.xsc && mv Pg.xsc Pg.c cc -c -I/usr/local/postgresql/REL7_4_29/include -I/usr/lib/perl5/auto/DBI -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPGLIBVERSION=70429 -DPGDEFPORT=5432 -O2 -g -DPERL_EXTMALLOC_DEF -Dmalloc=Perl_malloc -Dfree=Perl_mfree -Drealloc=Perl_realloc -Dcalloc=Perl_calloc -DVERSION=\"2.17.1\" -DXS_VERSION=\"2.17.1\" -fPIC "-I/usr/lib/perl/5.10/CORE" Pg.c cc -c -I/usr/local/postgresql/REL7_4_29/include -I/usr/lib/perl5/auto/DBI -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPGLIBVERSION=70429 -DPGDEFPORT=5432 -O2 -g -DPERL_EXTMALLOC_DEF -Dmalloc=Perl_malloc -Dfree=Perl_mfree -Drealloc=Perl_realloc -Dcalloc=Perl_calloc -DVERSION=\"2.17.1\" -DXS_VERSION=\"2.17.1\" -fPIC "-I/usr/lib/perl/5.10/CORE" dbdimp.c dbdimp.c: In function ‘pg_warn’: dbdimp.c:324: warning: format not a string literal and no format arguments cc -c -I/usr/local/postgresql/REL7_4_29/include -I/usr/lib/perl5/auto/DBI -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPGLIBVERSION=70429 -DPGDEFPORT=5432 -O2 -g -DPERL_EXTMALLOC_DEF -Dmalloc=Perl_malloc -Dfree=Perl_mfree -Drealloc=Perl_realloc -Dcalloc=Perl_calloc -DVERSION=\"2.17.1\" -DXS_VERSION=\"2.17.1\" -fPIC "-I/usr/lib/perl/5.10/CORE" quote.c cc -c -I/usr/local/postgresql/REL7_4_29/include -I/usr/lib/perl5/auto/DBI -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPGLIBVERSION=70429 -DPGDEFPORT=5432 -O2 -g -DPERL_EXTMALLOC_DEF -Dmalloc=Perl_malloc -Dfree=Perl_mfree -Drealloc=Perl_realloc -Dcalloc=Perl_calloc -DVERSION=\"2.17.1\" -DXS_VERSION=\"2.17.1\" -fPIC "-I/usr/lib/perl/5.10/CORE" types.c Running Mkbootstrap for DBD::Pg () chmod 644 Pg.bs rm -f blib/arch/auto/DBD/Pg/Pg.so LD_RUN_PATH="/usr/local/postgresql/REL7_4_29/lib" cc -shared -O2 -g -L/usr/local/lib -fstack-protector Pg.o dbdimp.o quote.o types.o -o blib/arch/auto/DBD/Pg/Pg.so \ -L/usr/local/postgresql/REL7_4_29/lib -lpq -lm \ chmod 755 blib/arch/auto/DBD/Pg/Pg.so cp Pg.bs blib/arch/auto/DBD/Pg/Pg.bs chmod 644 blib/arch/auto/DBD/Pg/Pg.bs PGINITDB="/usr/local/postgresql/REL7_4_29/bin/initdb" PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-signature.t .... skipped: Set the environment variable TEST_SIGNATURE to enable this test t/00_release.t ...... skipped: Test skipped unless environment variable RELEASE_TESTING is set t/00basic.t ......... ok t/01connect.t ....... Please wait, creating new database for testing t/01connect.t ....... 1/13 # # DBI Version 1.609 # DBD::Pg Version 2.17.1 # Perl Version 5.10.1 # OS linux # PostgreSQL (compiled) 70429 # PostgreSQL (target) 70429 # PostgreSQL (reported) PostgreSQL 7.4.29 on x86_64-unknown-linux-gnu, compiled by GCC gcc (Ubuntu 4.4.3-4ubuntu5) 4.4.3 # Default port 5432 # DBI_DSN dbi:Pg:db="postgres";port=5449;host=<pwd>/dbdpg_test_database/data/socket # DBI_USER ilmari # Test schema dbd_pg_testschema # LANG C # backslash_quote safe_encoding # client_encoding UNICODE # server_encoding UNICODE # Adjusted: initdb t/01connect.t ....... ok t/01constants.t ..... ok t/02attribs.t ....... ok t/03dbmethod.t ...... 1/531 Use of uninitialized value $result in concatenation (.) or string at t/03dbmethod.t line 46. RESULT is t/03dbmethod.t ...... ok t/03smethod.t ....... ok t/04misc.t .......... ok t/06bytea.t ......... ok t/07copy.t .......... ok t/08async.t ......... skipped: Cannot run asynchronous queries with pre-8.0 libraries. t/09arrays.t ........ ok t/12placeholders.t .. 1/235 # Failed test 'Calling do() with invalid crowded placeholders fails cleanly' # at t/12placeholders.t line 434. # got: '' # expected: '42601' # Looks like you failed 1 test of 235. t/12placeholders.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/235 subtests (less 17 skipped subtests: 217 okay) t/20savepoints.t .... ok t/99_perlcritic.t ... skipped: Test skipped unless environment variable RELEASE_TESTING is set t/99_pod.t .......... skipped: Test skipped unless environment variable RELEASE_TESTING is set t/99_spellcheck.t ... skipped: Test skipped unless environment variable RELEASE_TESTING is set t/99_yaml.t ......... skipped: Test skipped unless environment variable RELEASE_TESTING is set t/99cleanup.t ....... 1/1 pg_ctl: invalid option: --silent Try "pg_ctl --help" for more information. Removing test database directory t/99cleanup.t ....... ok Test Summary Report ------------------- t/12placeholders.t (Wstat: 256 Tests: 235 Failed: 1) Failed test: 103 Non-zero exit status: 1 Files=20, Tests=1647, 20 wallclock secs ( 0.38 usr 0.01 sys + 2.24 cusr 1.27 csys = 3.90 CPU) Result: FAIL Failed 1/20 test programs. 1/1647 subtests failed. make: *** [test_dynamic] Error 255
7.4, eh? After dusting off the mothballs, I was able to duplicate this and fix it in r14782. Note that this only shows up if you are compiling DBD::Pg against 7.4, not simply a target of 7.4.