Bug #61641 for Prima: ComboBox height when style cs::DropDown

Sat Sep 25 20:12:26 2010 user42 [...] zip.com.au - Ticket created

Subject:	ComboBox height when style cs::DropDown
Date:	Sun, 26 Sep 2010 10:12:10 +1000
To:	bug-Prima [...] rt.cpan.org
From:	Kevin Ryde <user42 [...] zip.com.au>

In Prima 1.28 a ComboBox made with cs::DropDown() seems to have a height of several lines, where I thought it would be a single line. The effect can be seen in the "listbox" sample program by adding style => cs::DropDown()

Sun Sep 26 11:24:43 2010 KARASIK [...] cpan.org - Correspondence added

Yes, true, this is the way ComboBox is implemented, - the height is defined differently for drop-down and the two other styles, which shows if the style is changed dynamically. I don't think that it is a bug, because explicit size of the whole widget must be respected; but I agree that the behavior is unexpected in the example.

Sun Sep 26 11:24:43 2010 The RT System itself - Status changed from 'new' to 'open'

Wed Sep 29 21:56:55 2010 user42 [...] zip.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #61641] ComboBox height when style cs::DropDown
Date:	Thu, 30 Sep 2010 11:55:47 +1000
To:	bug-Prima [...] rt.cpan.org
From:	Kevin Ryde <user42 [...] zip.com.au>

"KARASIK via RT" <bug-Prima@rt.cpan.org> writes: Show quoted text

> > the height is defined differently for drop-down and the two other > styles,

Is the cs::DropDown case meant to be more than one line high? Perhaps I don't understand how it's supposed to work. Show quoted text

> explicit size of the whole widget must be respected;

Yes. I got the effect I thought I wanted by making a dummy combo of the default style, getting its height, then forcing that height on the cs::DropDown ones :-) -- The sigfile one-line movie reviews series: "Cold Fever" -- easily the best Japanese-Icelandic road movie ever made.

Thu Sep 30 02:34:20 2010 KARASIK [...] cpan.org - Correspondence added

Ah, you need the default height, not the height after changing styles - yes, I agree this can be seen as a kind of a bug. Because some other widgets (esp. InputLine) are smart about what their default height would be, but not the combo. I agree, it could've been done better, where the combo sets the default height if the style is drop-down. Then indeed, you need to specify the height explicitly. $window->font->height+4 is a good default value - not elegant, but fault-proof. It is actually the same formula used by InputLine when it sets its default height (see line 55 in InputLine.pm). I'm not sure if the problem is worth investigating and patching, but if you feel like trying, welcome!

Mon Jan 10 17:25:41 2011 KARASIK [...] cpan.org - Status changed from 'open' to 'resolved'