Bug #61636 for KinoSearch: Please provide a CHANGELOG!!

Sat Sep 25 18:50:27 2010 jdrago_999 [...] yahoo.com - Ticket created

Subject:

Please provide a CHANGELOG!!

Hello, It would be swell if you provided a changelog to go along with the work. Especially since this is sort of, well, complicated. Anyone who might use this code would greatly benefit from simply knowing what was changed (and if you have the spare moment) why it was changed. Thanks.

Sat Sep 25 18:53:43 2010 jdrago_999 [...] yahoo.com - Correspondence added

On Sat Sep 25 18:50:27 2010, JOHND wrote: Show quoted text

> Hello, > > It would be swell if you provided a changelog to go along with the work. > > Especially since this is sort of, well, complicated. Anyone who might > use this code would greatly benefit from simply knowing what was changed > (and if you have the spare moment) why it was changed. > > Thanks.

Oh yeah - especially when the changelog is 49,000+ lines long. http://search.cpan.org/diff/KinoSearch-0.30_112-KinoSearch-0.30_12.-w.diff

Sat Sep 25 18:53:44 2010 jdrago_999 [...] yahoo.com - Status changed from 'new' to 'open'

Sat Sep 25 18:54:41 2010 jdrago_999 [...] yahoo.com - Correspondence added

s/changelog/diff/s

Sat Sep 25 19:01:54 2010 CREAMYG [...] cpan.org - Correspondence added

On Sat Sep 25 18:53:43 2010, JOHND wrote: Show quoted text

> > It would be swell if you provided a changelog to go along with the > > work.

Please see the file entitled "Changes". Show quoted text

> Oh yeah - especially when the changelog is 49,000+ lines long.

There were a lot of cosmetic changes in this update. In particular, all files with a ".bp" extension changed to a ".cfh" extension, which was responsible for the bulk of that diff.

Mon Sep 27 14:58:09 2010 jdrago_999 [...] yahoo.com - Correspondence added

On Sat Sep 25 19:01:54 2010, CREAMYG wrote: Show quoted text

> On Sat Sep 25 18:53:43 2010, JOHND wrote:

> > > It would be swell if you provided a changelog to go along with the > > > work.

> > Please see the file entitled "Changes". >

> > Oh yeah - especially when the changelog is 49,000+ lines long.

> > There were a lot of cosmetic changes in this update. In particular, all > files with a ".bp" extension changed to a ".cfh" extension, which was > responsible for the bulk of that diff. >

Ah I see. http://search.cpan.org/~creamyg/KinoSearch-0.30_12/ No "Changes" file appears on that page, but it does appear here: http://cpansearch.perl.org/src/CREAMYG/KinoSearch-0.30_12/ I'll double-check next time. Thanks for an *excellent* piece of work. Best regards, John Drago

Mon Sep 27 14:58:10 2010 jdrago_999 [...] yahoo.com - Status changed from 'open' to 'resolved'

Mon Sep 27 20:40:20 2010 CREAMYG [...] cpan.org - Correspondence added

On Mon Sep 27 14:58:09 2010, JOHND wrote: Show quoted text

> http://search.cpan.org/~creamyg/KinoSearch-0.30_12/ > > No "Changes" file appears on that page, but it does appear here: > > http://cpansearch.perl.org/src/CREAMYG/KinoSearch-0.30_12/

Aha! In order to make that search.cpan.org page comprehensible, I have to add most files in the distro to the "no_index" section of META.yml -- otherwise search.cpan.org clutters it up with a bunch of private classes, build files, etc. This is done automatically, and Changes was being added to "no_index" erroneously. Fixed by r6366: =================================================================== --- buildlib/KinoSearch/Build.pm (revision 6360) +++ buildlib/KinoSearch/Build.pm (working copy) @@ -619,8 +619,8 @@ my @excluded_files; for my $entry (@manifest_entries) { - # Allow README. - next if $entry =~ m#^README#; + # Allow README and Changes. + next if $entry =~ m#^(README|Changes)#; Show quoted text

> Thanks for an *excellent* piece of work.

Thanks for the kind words, and for the bug report! Cheers, Marvin Humphrey

Mon Sep 27 20:40:21 2010 The RT System itself - Status changed from 'resolved' to 'open'

Thu Sep 30 20:36:57 2010 CREAMYG [...] cpan.org - Severity Critical changed to Normal

Thu Sep 30 20:36:58 2010 CREAMYG [...] cpan.org - Fixed in 0.30_121 added

Thu Sep 30 20:36:59 2010 CREAMYG [...] cpan.org - Correspondence added

I've confirmed that the Changes file is visible in the search.cpan.org display as of release 0.30_121. I'm changing the severity of this ticket to "normal" because the file was never missing (just not visible due to the no_index setting) and resolving the issue.

Thu Sep 30 20:37:01 2010 CREAMYG [...] cpan.org - Status changed from 'open' to 'resolved'