Bug #61592 for DBIx-VersionedDDL: Suggest exposing a method to allow override on SQL preprocessing

Thu Sep 23 13:07:31 2010 stuart [...] morungos.com - Ticket created

Subject:

Suggest exposing a method to allow override on SQL preprocessing

Hi Dan, This looks like a great module that does exactly what we need, and but for a very small issue, I'd be using it now. We have to support two different DB types, and it's hard to write portable SQL. I also, for maintenance, don't like to just have parallel files for each system. Instead, I want to be able to preprocess the SQL, e.g., using Template Toolkit. This is all private, can I suggest a small refactor to expose and allow this preprocessing to be done via a subclass, or possibly more as a convenience as a callback. I can write a patch for you if you like. All the best Stuart

Sun Sep 26 19:17:12 2010 dan.horne [...] redbone.co.nz - Correspondence added

Subject:	Re: [rt.cpan.org #61592] Suggest exposing a method to allow override on SQL preprocessing
Date:	Mon, 27 Sep 2010 11:17:01 +1200
To:	bug-DBIx-VersionedDDL [...] rt.cpan.org
From:	Dan Horne <dan.horne [...] redbone.co.nz>

Hi Stuart I'm happy for any patches that provide callback functionality as long as they don't break any existing features. Flick me your patch, including appropriate tests, and I'll release asap Dan On 24 September 2010 05:07, Stuart Watt via RT < bug-DBIx-VersionedDDL@rt.cpan.org> wrote: Show quoted text

> Thu Sep 23 13:07:31 2010: Request 61592 was acted upon. > Transaction: Ticket created by SNKWATT > Queue: DBIx-VersionedDDL > Subject: Suggest exposing a method to allow override on SQL > preprocessing > Broken in: 0.12 > Severity: Wishlist > Owner: Nobody > Requestors: stuart@morungos.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=61592 > > > > Hi Dan, > > This looks like a great module that does exactly what we need, and but for > a very small issue, I'd be using it now. We have to support two different > DB types, and it's hard to write portable SQL. I also, for maintenance, > don't like to just have parallel files for each system. Instead, I want to > be able to preprocess the SQL, e.g., using Template Toolkit. This is all > private, can I suggest a small refactor to expose and allow this > preprocessing to be done via a subclass, or possibly more as a convenience > as a callback. I can write a patch for you if you like. > > All the best > Stuart >

Sun Sep 26 19:17:13 2010 The RT System itself - Status changed from 'new' to 'open'

Sun Oct 24 13:11:59 2010 JIRA [...] cpan.org - Correspondence added

RT-Send-CC:

dan.horne [...] redbone.co.nz

On Sun Sep 26 19:17:12 2010, dan.horne@redbone.co.nz wrote: Show quoted text

> Hi Stuart > > I'm happy for any patches that provide callback functionality as long as > they don't break any existing features. Flick me your patch, including > appropriate tests, and I'll release asap

Hi, here is my shot at going modular in version script processing. It uses 'MooseX::Object::Pluggable' to load plugins (roles). The current behavior is preserved I used the current code in a default plugin. When can specify custom plugin in an environment variable. I used MooseX::Attribute::ENV. What do yo think? Regards, Jiri P.S. Note there is also a bug in the migrate script that sets password to the value of username: $args->{user} = $user if $user; $args->{pass} = $user if $pass;

Subject:

process_script_plugin.patch

Message body is not shown because it is too large.

Mon Nov 15 20:24:41 2010 dhorne [...] cpan.org - Correspondence added

Latest version 0.15 supports plugins where custom functionality can be injected

Mon Nov 15 20:24:41 2010 dhorne [...] cpan.org - Status changed from 'open' to 'resolved'