Skip Menu |

This queue is for tickets about the Business-OnlinePayment-eSelectPlus CPAN distribution.

Report information
The Basics
Id: 61376
Status: resolved
Priority: 0/
Queue: Business-OnlinePayment-eSelectPlus

People
Owner: Nobody in particular
Requestors: DONOR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.01
Fixed in: 0.03

Attachments
Business-OnlinePayment-eSelectPlus-0.02.tar.gz



Subject: production server; test_transaction; HTTP errors; Set avs-code; ResponseCode vs ISO
We have made several enhancements to Business::OnlinePayment::eSelectPlus for a customer who had chosen Moneris eSelectPlus as their payment gateway. We hope these enhancements can be incorporated into BOP::eSelectPlus on CPAN. 0.02 2008-04-02 - Server name of production server - Honor test_transaction mode in submit, by overriding user/pass, as well as setting server name to QA server. - Check HTTP errors. - Set avs-code. - Use ResponseCode rather than ISO for result-code. We do not have enough info about "ISO" response codes to make use of them. There may be good reasons why the ISO codes could be preferable, but we would need more information. For now, the ResponseCode. - Use AuthCode rather then Txn-number for authorization. - Remove extra spaces and other odd characters in Message. - by Randall Whitman <www.whizman.com> on contract to DonorWare LLC dba donor.com <cpan @ donor . com>. % md5sum Business-OnlinePayment-eSelectPlus-0.02.tar.gz 59205de243c2d62a1b960f836f6502a8 Business-OnlinePayment-eSelectPlus-0.02.tar.gz % sha1sum Business-OnlinePayment-eSelectPlus-0.02.tar.gz 38f6ba261b8bd7c28d0f1b4d6bc46adc6912b782 Business-OnlinePayment-eSelectPlus-0.02.tar.gz
Subject: Business-OnlinePayment-eSelectPlus-0.02.tar.gz

Message body not shown because it is not plain text.

On Wed Sep 15 21:05:09 2010, DONOR wrote: Show quoted text
> We have made several enhancements to > Business::OnlinePayment::eSelectPlus for a customer who had chosen > Moneris eSelectPlus as their payment gateway. We hope these > enhancements can be incorporated into BOP::eSelectPlus on CPAN.
Applied your patch with minor adjustments. However, the module does not pass its tests; gets "Request was not allowed at this time" back from the gateway. Before we release this to CPAN, it would be best if the code passed its tests. Please download the updated code and let me know if you have a fix fore the test failures: http://freeside.biz/cgi-bin/viewvc.cgi/Business-OnlinePayment-eSelectPlus.tar.gz?view=tar -Ivan
Show quoted text
> However, the module does not pass its tests; gets "Request was not > allowed at this time" back from the gateway. > Before we release this to CPAN, it would be best if the code passed > its tests. > Please download the updated code and let me know if you have a fix fore > the test failures: freeside.biz ...
In my tests, 0.01 fails 2/7; the version that we have in-house, as posted 2010-09-15, PASSes "make test"; and from the freeside.biz URL you provided, also PASS. My tests are on ubuntu-10.04 linux. The Moneris eSelectPlus test server appears to have intermittent outages. -Randall [0.01, ubuntu-10.04] Business-OnlinePayment-eSelectPlus-0.01> make test| & tee test.log PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/bad_card.t ........... ok t/bop.t ................ ok t/credit_card.t ........ ok t/crypt_bad_card.t ..... Failed 1/1 subtests HOLD CARD * CALL = t/crypt_credit_card.t .. Failed 1/1 subtests t/crypt_load.t ......... ok t/load.t ............... ok Test Summary Report ------------------- t/crypt_bad_card.t (Wstat: 0 Tests: 1 Failed: 1) Failed test: 1 t/crypt_credit_card.t (Wstat: 0 Tests: 1 Failed: 1) Failed test: 1 Files=7, Tests=7, 5 wallclock secs ( 0.05 usr 0.02 sys + 0.28 cusr 0.06 csys = 0.41 CPU) Result: FAIL Failed 2/7 test programs. 2/7 subtests failed. make: *** [test_dynamic] Error 255 [in-house, as posted 2010-09-15] (perl-5.10.1/ubuntu-10.04/x86-64 & perl-5.8.5/CentOS-4.5/i686) cp eSelectPlus.pm blib/lib/Business/OnlinePayment/eSelectPlus.pm PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Name "Business::OnlinePayment::eSelectPlus::DEBUG" used only once: possible typo at t/bad_card.t line 15. t/bad_card.t ........... ok t/bop.t ................ ok t/credit_card.t ........ ok Argument "200 OK" isn't numeric in numeric ne (!=) at /home/randall/DonorWare/Src/Trunk/cpan-contribs/Business-OnlinePayment-eSelectPlus/blib/lib/Business/OnlinePayment/eSelectPlus.pm line 139. Use of uninitialized value in hash element at /home/randall/DonorWare/Src/Trunk/cpan-contribs/Business-OnlinePayment-eSelectPlus/blib/lib/Business/OnlinePayment/eSelectPlus.pm line 166. Use of uninitialized value in scalar assignment at (eval 29) line 1. t/crypt_bad_card.t ..... ok Argument "200 OK" isn't numeric in numeric ne (!=) at /home/randall/DonorWare/Src/Trunk/cpan-contribs/Business-OnlinePayment-eSelectPlus/blib/lib/Business/OnlinePayment/eSelectPlus.pm line 139. Use of uninitialized value in hash element at /home/randall/DonorWare/Src/Trunk/cpan-contribs/Business-OnlinePayment-eSelectPlus/blib/lib/Business/OnlinePayment/eSelectPlus.pm line 166. Use of uninitialized value in scalar assignment at (eval 29) line 1. t/crypt_credit_card.t .. ok t/crypt_load.t ......... ok t/load.t ............... ok All tests successful. Files=7, Tests=7, 4 wallclock secs ( 0.05 usr 0.02 sys + 0.32 cusr 0.03 csys = 0.42 CPU) Result: PASS [freesize.biz, md5 0cbe93bb0b6dbfe2c497e191948822e3; ubuntu-10.04] Business-OnlinePayment-eSelectPlus-20100919> make |& tee make.log cp eSelectPlus.pm blib/lib/Business/OnlinePayment/eSelectPlus.pm Manifying blib/man3/Business::OnlinePayment::eSelectPlus.3pm randall-desktop:~/<1>Build/Business-OnlinePayment-eSelectPlus-20100919> make test| & tee test.log PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/bad_card.t ........... ok t/bop.t ................ ok t/credit_card.t ........ ok t/crypt_bad_card.t ..... ok t/crypt_credit_card.t .. ok t/crypt_load.t ......... ok t/load.t ............... ok All tests successful. Files=7, Tests=7, 5 wallclock secs ( 0.02 usr 0.02 sys + 0.29 cusr 0.04 csys = 0.37 CPU) Result: PASS
* The version at the freeside.biz URL posted 2010-09-19, PASSes all tests (when the server is up). * By comparison, 0.01 fails 2 tests. (In case prior post was too verbose and not direct/clear enough.) Show quoted text
patch included in the 0.03 release. thanks!