Sun Sep 12 00:54:08 2010eponymousalias [...] yahoo.com - Ticket created
Subject:
bad implementation of bind_param
Date:
Sat, 11 Sep 2010 21:53:59 -0700 (PDT)
To:
bug-DBI [...] rt.cpan.org
From:
eponymous alias <eponymousalias [...] yahoo.com>
This code in SqlEngine.pm looks wrong:
685 my $type = ref $attr eq "HASH" ? $attr->{TYPE} : $attr;
686 if ( $attr == DBI::SQL_BIGINT()
Shouldn't $type be referenced in the if and
elsif clauses instead of $attr ?
Sun Sep 12 05:20:01 2010HMBRAND [...] cpan.org - Correspondence added
Do you have a (failing) test case to demonstrate the error?
If so, we can use that as a regression test if it is indeed wrong
Sun Sep 12 05:20:03 2010The RT System itself - Status changed from 'new' to 'open'
Sun Sep 12 19:41:43 2010eponymousalias [...] yahoo.com - Correspondence added
Subject:
Re: [rt.cpan.org #61281] bad implementation of bind_param
Date:
Sun, 12 Sep 2010 16:41:29 -0700 (PDT)
To:
bug-DBI [...] rt.cpan.org
From:
eponymous alias <eponymousalias [...] yahoo.com>
Show quoted text
> Do you have a (failing) test case to
> demonstrate the error? If so, we can use that
> as a regression test if it is indeed wrong.
No, I do not. I spotted the error when reading
the code looking to find out how bind_param()
actually works, rather than through an observed
failure. Once you look at the code and look at
the documentation for this routine, the error is
pretty obvious.
I suspect this copy of bind_param might be
overridden by individual drivers in some cases,
but someone who knows the package better than I
can make that judgment. That might mask the
effect of this bug.
Re: [rt.cpan.org #61281] bad implementation of bind_param
Date:
Mon, 13 Sep 2010 23:11:13 +0100
To:
eponymous alias via RT <bug-DBI [...] rt.cpan.org>
From:
Tim Bunce <Tim.Bunce [...] pobox.com>
On Sun, Sep 12, 2010 at 07:41:45PM -0400, eponymous alias via RT wrote:
Show quoted text
>
> No, I do not. I spotted the error when reading
> the code looking to find out how bind_param()
> actually works, rather than through an observed
> failure. Once you look at the code and look at
> the documentation for this routine, the error is
> pretty obvious.
RT for rt.cpan.org