Skip Menu |

This queue is for tickets about the Email-MIME-CreateHTML CPAN distribution.

Report information
The Basics
Id: 61245
Status: resolved
Priority: 0/
Queue: Email-MIME-CreateHTML

People
Owner: vanstyn [...] cpan.org
Requestors: w.phillip.moore@gmail.com (no email address)
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.030
Fixed in: 1.040



Subject: Test suite fails due to missing dependencies not listed in PREREQ_PM
When installing Email::MIME::CreateHTML, the test suite fails if the LWP and Filesystem resolver modules can't be loaded. The dependencies for these modules are not listed in the Makefile.PL, so it's not possible for automated tools like cpanp/cpanm/etc to satisfy those dependencies. I would like to suggest that either the dependencies be listed in Makefile.PL, or the test suite changed to skip, instead of fail, when those dependencies are not present. Simply installing the missing dependencies results in successful tests. The attached patch added PREREF_PM entries for URI::file and LWP::UserAgent, which were the two modules that LWP.pm and Filesystem.pm were unable to find.
Subject: Email-MIME-CreateHTML-1.030-prereq.patch
diff -rc Email-MIME-CreateHTML-1.030/Makefile.PL Email-MIME-CreateHTML-1.030-prereq/Makefile.PL *** Email-MIME-CreateHTML-1.030/Makefile.PL 2010-02-12 09:44:43.000000000 -0800 --- Email-MIME-CreateHTML-1.030-prereq/Makefile.PL 2010-09-10 09:49:23.000000000 -0700 *************** *** 13,18 **** --- 13,20 ---- File::Slurp::WithinPolicy => 0, MIME::Types => 0, Data::Serializer => 0, + URI::file => 0, + LWP::UserAgent => 0, }, ABSTRACT_FROM => 'lib/Email/MIME/CreateHTML.pm', AUTHOR => 'British Broadcasting Corporation',
Converted to use Dist::Zilla for 1.040 release, which now finds all the needed deps automatically, including LWP, etc