| Subject: | Reporting a bug, and a patch to fix it: _convert_resolution() issue |
| Date: | Thu, 9 Sep 2010 14:30:08 -0400 |
| To: | <bug-JIRA-Client [...] rt.cpan.org> |
| From: | "Ken Beal" <KBeal [...] crosscountry-auto.com> |
Hi,
Thank you so much for this module! It has made life easier here.
I've found an issue and corrected it in our local Perl module, and
wanted to report it back upstream.
The issue is in the sub _convert_resolution(), the fix is to change
"{name}" to "{id}". Below is the new code (with a "BUGBUG" comment
showing the line I changed, which you could remove):
sub _convert_resolution {
my ($self, $hash) = @_;
my $resolution = $hash->{resolution};
if ($resolution =~ /\D/) {
my $resolutions = $self->get_resolutions();
croak "There is no resolution called '$resolution'.\n"
unless exists $resolutions->{$resolution};
$hash->{resolution} = $resolutions->{$resolution}{id}; # BUGBUG
changed {name} to {id}
}
return;
}
Sincerely,
--
Ken Beal
Senior Software Engineer, Build/Release
Cross Country Automotive Services
One Cabot Road
Medford, MA 02155
p: (781) 306-3605
m: (978) 423-8977
e: kbeal@crosscountry-auto.com <mailto:kbeal@crosscountry-auto.com>
Confidentiality Note: This e-mail message and any attachments may contain
confidential or privileged information. If you are not the intended recipient,
please notify me immediately by replying to this message and destroy all
copies of this message and any attachments. Thank you.