Skip Menu |

This queue is for tickets about the HTTP-Parser-XS CPAN distribution.

Report information
The Basics
Id: 61133
Status: resolved
Priority: 0/
Queue: HTTP-Parser-XS

People
Owner: Nobody in particular
Requestors: taro.nishino [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: HTTP-Parser-XS-0.08 compilation failure
Hi Kazuho, The compilation using MSVC++7.0 ends in failure because of the violation of the so-called C89 rules. So, may I ask you a favour? Could you apply attached patches? Best regards, Taro Nishino
Subject: XS.xs.diff.txt
--- XS.xs.orig Tue Sep 7 21:12:00 2010 +++ XS.xs Tue Sep 7 21:13:47 2010 @@ -63,6 +63,7 @@ static char* url_decode(const char* s, size_t len) { + dTHX; char* dbuf, * d; size_t i;
Subject: picohttpparser.c.diff.txt
--- picohttpparser/picohttpparser.c.orig Tue Sep 7 20:54:36 2010 +++ picohttpparser/picohttpparser.c Tue Sep 7 20:55:18 2010 @@ -109,12 +109,12 @@ static const char* parse_int(const char* buf, const char* buf_end, int* value, int* ret) { + int v = 0; CHECK_EOF(); if (! ('0' <= *buf && *buf <= '9')) { *ret = -1; return NULL; } - int v = 0; for (; ; ++buf) { CHECK_EOF(); if ('0' <= *buf && *buf <= '9') {
Thank you for the patch. Applied it and released 0.09.